From: "Andreas Färber" <afaerber@suse.de>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] firmware_abi: move to include/hw/nvram/
Date: Thu, 30 May 2013 17:29:38 +0200 [thread overview]
Message-ID: <51A77062.8050503@suse.de> (raw)
In-Reply-To: <1369906048-22212-3-git-send-email-mst@redhat.com>
Am 30.05.2013 11:30, schrieb Michael S. Tsirkin:
> firmware_abi.h with structs for OpenBIOS landed in hw/sparc/ by mistake
> - move it to hw/nvram/ alongside fw_cfg.h. In addition to sparc it's
> included from ppc mac_nvram.c and will need to include it from prep.c in
> the future.
>
> Cc: Andreas Färber <afaerber@suse.de>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/sparc/sun4m.c | 2 +-
> hw/sparc64/sun4u.c | 2 +-
> include/hw/nvram/openbios_firmware_abi.h | 73 ++++++++++++++++++++++++++++++++
> include/hw/sparc/firmware_abi.h | 73 --------------------------------
> 4 files changed, 75 insertions(+), 75 deletions(-)
> create mode 100644 include/hw/nvram/openbios_firmware_abi.h
> delete mode 100644 include/hw/sparc/firmware_abi.h
Thanks for picking my suggestion up! Same applies as for other patch: In
general
Acked-by: Andreas Färber <afaerber@suse.de>
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-05-30 15:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 9:30 [Qemu-devel] [PATCH 0/2] fixup some fallback from tree reorg Michael S. Tsirkin
2013-05-30 9:30 ` [Qemu-devel] [PATCH 1/2] dec.c - move to pci-bridge Michael S. Tsirkin
2013-05-30 15:27 ` Andreas Färber
2013-05-30 17:37 ` Michael S. Tsirkin
2013-05-30 9:30 ` [Qemu-devel] [PATCH 2/2] firmware_abi: move to include/hw/nvram/ Michael S. Tsirkin
2013-05-30 15:29 ` Andreas Färber [this message]
2013-05-30 13:04 ` [Qemu-devel] [PATCH 0/2] fixup some fallback from tree reorg Paolo Bonzini
2013-05-30 13:07 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A77062.8050503@suse.de \
--to=afaerber@suse.de \
--cc=blauwirbel@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).