From: Laszlo Ersek <lersek@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Hu Tao <hutao@cn.fujitsu.com>,
qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] pvpanic: use FWCfgState explicitly
Date: Thu, 30 May 2013 17:56:39 +0200 [thread overview]
Message-ID: <51A776B7.6010301@redhat.com> (raw)
In-Reply-To: <51A77319.9090702@redhat.com>
On 05/30/13 17:41, Paolo Bonzini wrote:
> Il 30/05/2013 17:05, Laszlo Ersek ha scritto:
>> But, again object_resolve_path() returns pointer-to-Object. I'm checking
>> "struct Object" in "include/qom/object.h", and it suggests that derived
>> structs should embed Object as first member. However FWCfgState is *not*
>> such a derived member. What's going on here?
>>
>> http://thread.gmane.org/gmane.comp.emulators.qemu/201544/focus=201564
>> http://thread.gmane.org/gmane.comp.emulators.qemu/204452/focus=204450
>
> FWCfgState embeds Object via SysBusDevice and DeviceState.
Clearly an evil trick by a devious mind.
Thanks :)
Laszlo
next prev parent reply other threads:[~2013-05-30 16:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 13:27 [Qemu-devel] [PATCH 0/3] fw_cfg: misc fixes Michael S. Tsirkin
2013-05-30 13:27 ` [Qemu-devel] [PATCH 1/3] pvpanic: use FWCfgState explicitly Michael S. Tsirkin
2013-05-30 15:05 ` Laszlo Ersek
2013-05-30 15:41 ` Paolo Bonzini
2013-05-30 15:56 ` Laszlo Ersek [this message]
2013-05-30 16:03 ` Laszlo Ersek
2013-05-30 16:01 ` Paolo Bonzini
2013-05-30 17:36 ` Michael S. Tsirkin
2013-05-30 13:28 ` [Qemu-devel] [PATCH 2/3] fw_cfg: add API to find FW cfg object Michael S. Tsirkin
2013-05-30 16:06 ` Laszlo Ersek
2013-05-31 1:47 ` Hu Tao
2013-05-30 13:28 ` [Qemu-devel] [PATCH 3/3] fw_cfg: fw_cfg is a singleton Michael S. Tsirkin
2013-05-30 16:06 ` [Qemu-devel] [PATCH 0/3] fw_cfg: misc fixes Laszlo Ersek
2013-05-31 1:51 ` Hu Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A776B7.6010301@redhat.com \
--to=lersek@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).