From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ui5L3-0007Gf-Re for qemu-devel@nongnu.org; Thu, 30 May 2013 12:04:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ui5Kx-0006PL-Bl for qemu-devel@nongnu.org; Thu, 30 May 2013 12:04:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1922) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ui5Kw-0006PE-VK for qemu-devel@nongnu.org; Thu, 30 May 2013 12:04:23 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4UG4MVT027848 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 30 May 2013 12:04:22 -0400 Message-ID: <51A77914.1030207@redhat.com> Date: Thu, 30 May 2013 18:06:44 +0200 From: Laszlo Ersek MIME-Version: 1.0 References: <1369920427-18274-1-git-send-email-mst@redhat.com> In-Reply-To: <1369920427-18274-1-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] fw_cfg: misc fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org On 05/30/13 15:27, Michael S. Tsirkin wrote: > Here are some misc fixes to the fw cfg object > handling. > I've queued them on my pci branch temporarily > as it's useful to cleanup some pci things. > I'm using this with Laszlo's cleanup patch > that got rid of void * in pc.c too - > that's queued there as well. > > Please review and comment. > > Michael S. Tsirkin (3): > pvpanic: use FWCfgState explicitly > fw_cfg: add API to find FW cfg object > fw_cfg: fw_cfg is a singleton > > hw/misc/pvpanic.c | 4 ++-- > hw/nvram/fw_cfg.c | 18 +++++++++++++----- > include/hw/nvram/fw_cfg.h | 2 ++ > 3 files changed, 17 insertions(+), 7 deletions(-) > series Reviewed-by: Laszlo Ersek