From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54733) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ui5jp-0003Kl-Ga for qemu-devel@nongnu.org; Thu, 30 May 2013 12:30:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ui5ji-0002c7-W3 for qemu-devel@nongnu.org; Thu, 30 May 2013 12:30:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:65022) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ui5ji-0002br-OW for qemu-devel@nongnu.org; Thu, 30 May 2013 12:29:58 -0400 Message-ID: <51A77F13.3040400@redhat.com> Date: Thu, 30 May 2013 18:32:19 +0200 From: Laszlo Ersek MIME-Version: 1.0 References: <1369911913-10934-1-git-send-email-mst@redhat.com> <1369911913-10934-6-git-send-email-mst@redhat.com> In-Reply-To: <1369911913-10934-6-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 5/5] pc: pci-info add compat support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Anthony Liguori , qemu-devel@nongnu.org On 05/30/13 13:07, Michael S. Tsirkin wrote: > /* PC hardware initialisation */ > static void pc_init1(MemoryRegion *system_memory, > @@ -122,6 +122,7 @@ static void pc_init1(MemoryRegion *system_memory, > } > > guest_info = pc_guest_info_init(below_4g_mem_size, above_4g_mem_size); > + guest_info->compat_v1_5 = guest_info_compat_v1_5; I believe I can see the advantage of delaying this "compat_v1_5" until init-done-notifier time: init code gradually building up / rewriting guest_info doesn't have to tiptoe around conditions. Style: would it be worth passing "guest_info_compat_v1_5" as a parameter to pc_guest_info_init()? Currently you have an _init() function that partially initializes the struct, and right after _init() returns you fill in what's still missing form basic initialization. No more comments for the series. Thanks, Laszlo