From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33072) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiBke-0004r3-Rb for qemu-devel@nongnu.org; Thu, 30 May 2013 18:55:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UiBkX-0005Nv-LU for qemu-devel@nongnu.org; Thu, 30 May 2013 18:55:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42600) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiBkX-0005Nn-D4 for qemu-devel@nongnu.org; Thu, 30 May 2013 18:55:13 -0400 Message-ID: <51A7D8CC.5070107@redhat.com> Date: Thu, 30 May 2013 16:55:08 -0600 From: Eric Blake MIME-Version: 1.0 References: <1369917299-5725-1-git-send-email-stefanha@redhat.com> <1369917299-5725-8-git-send-email-stefanha@redhat.com> In-Reply-To: <1369917299-5725-8-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2VSAUJJRJMFCCKAVUOGTT" Subject: Re: [Qemu-devel] [PATCH v5 07/11] blockdev: rename BlkTransactionStates to singular List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , Fam Zheng , qemu-devel@nongnu.org, xiawenc@linux.vnet.ibm.com, imain@redhat.com, Paolo Bonzini , dietmar@proxmox.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2VSAUJJRJMFCCKAVUOGTT Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/30/2013 06:34 AM, Stefan Hajnoczi wrote: > The QMP 'transaction' command keeps a list of in-flight transactions. > The transaction state structure is called BlkTransactionStates even > though it only deals with a single transaction. The only plural thing > is the linked list of transaction states. >=20 > I find it confusing to call the single structure "States". This patch > renames it to "State", just like BlockDriverState is singular. >=20 > Signed-off-by: Stefan Hajnoczi > --- > blockdev.c | 104 ++++++++++++++++++++++++++++++-----------------------= -------- > 1 file changed, 52 insertions(+), 52 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2VSAUJJRJMFCCKAVUOGTT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRp9jMAAoJEKeha0olJ0NqhtUH/3taexN/NqhB4YLHOTvYgKHD vAsS6NJ5cOU1sOrJqnXhV/gxckfv8xcMpCOhBC8UMhxQdRMG1A1txpB630R1EK5J AewjGBmEzKD4OCpT7xU5kuFbYQygydltrIwVqw8jCb519adIkdP8J22k8OmwwuAq 3px3NQeJWqtdGL6HmLB7xcYLfqhHmj/WjvkiRWOCJ3eDOtvG82jl4AND2bhCe0RI 5DAAGkS0kK4BjqAzdSURErgC6SI0F/pTJDRXO/pNyfW06qFu/Xu/SouY2pAtSAgk pTdNQB9WwYiamSqzg/wwXzibmoJm175Z9iUDnPkYUCMYRj4aOOHjzdBoLhV7rqA= =ImPr -----END PGP SIGNATURE----- ------enig2VSAUJJRJMFCCKAVUOGTT--