From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33950) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiBn2-0005t1-8L for qemu-devel@nongnu.org; Thu, 30 May 2013 18:57:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UiBn1-0006AL-8i for qemu-devel@nongnu.org; Thu, 30 May 2013 18:57:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37141) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiBn0-0006AH-Vl for qemu-devel@nongnu.org; Thu, 30 May 2013 18:57:47 -0400 Message-ID: <51A7D951.50909@redhat.com> Date: Thu, 30 May 2013 16:57:21 -0600 From: Eric Blake MIME-Version: 1.0 References: <1369917299-5725-1-git-send-email-stefanha@redhat.com> <1369917299-5725-9-git-send-email-stefanha@redhat.com> In-Reply-To: <1369917299-5725-9-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2CSQFAWHFXTNUGEGNQPUE" Subject: Re: [Qemu-devel] [PATCH v5 08/11] blockdev: allow BdrvActionOps->commit() to be NULL List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , Fam Zheng , qemu-devel@nongnu.org, xiawenc@linux.vnet.ibm.com, imain@redhat.com, Paolo Bonzini , dietmar@proxmox.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2CSQFAWHFXTNUGEGNQPUE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/30/2013 06:34 AM, Stefan Hajnoczi wrote: > Some QMP 'transaction' types don't need to do anything on .commit(). > Make .commit() optional just like .abort(). >=20 > The "drive-backup" action will take advantage of this, it only needs to= > cancel the block job on .abort(). Other block job actions will probabl= y > follow the same pattern, so allow .commit() to be NULL. >=20 > Suggested-by: Eric Blake > Signed-off-by: Stefan Hajnoczi > --- > blockdev.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake Is it worth enforcing that at least one of commit or abort is supplied (that is, assert if the user codes up an action that has neither callback)? Or is that just overkill? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2CSQFAWHFXTNUGEGNQPUE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRp9lRAAoJEKeha0olJ0Nq3fsH/20l3QwX4ZACaQ5feHWnR/EK ubj++H8OprtGxScLbbXyL3QnIWjc9RlzYnfn372I0miVl5nbENdvyrPIwq8+kaeN cuY9yyZhXf17dweq3csKC+2qt+Qmh5vBbvCsK6tPxT9ACWHVbxN8OkCWPLsVrt0R bOr6x8TeQVOwOJAGvs1k8YTc60XgUci3FkS6DLHMMQ0SlQWWn+8nOkgPmnIbo0Ss XOe7udAWNOMEw2+fZFQJR04Y9i3doTFitJMxbHFd8HAHNeWrWUrXJ2X5IBU5i6qT 5TPB2e3jHCJImdNIUemA5FcXTaqlUWYw3c33SdhjR0rZ036rdAfQAV+4rGmgbIM= =dGKM -----END PGP SIGNATURE----- ------enig2CSQFAWHFXTNUGEGNQPUE--