From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32988)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wdongxu@linux.vnet.ibm.com>) id 1UiEuj-0000I0-K5
	for qemu-devel@nongnu.org; Thu, 30 May 2013 22:17:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wdongxu@linux.vnet.ibm.com>) id 1UiEuf-0007nD-K5
	for qemu-devel@nongnu.org; Thu, 30 May 2013 22:17:57 -0400
Received: from e7.ny.us.ibm.com ([32.97.182.137]:60412)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wdongxu@linux.vnet.ibm.com>) id 1UiEuf-0007n0-G1
	for qemu-devel@nongnu.org; Thu, 30 May 2013 22:17:53 -0400
Received: from /spool/local
	by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <wdongxu@linux.vnet.ibm.com>;
	Thu, 30 May 2013 22:17:53 -0400
Received: from d01relay06.pok.ibm.com (d01relay06.pok.ibm.com [9.56.227.116])
	by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 5855238C8045
	for <qemu-devel@nongnu.org>; Thu, 30 May 2013 22:17:50 -0400 (EDT)
Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216])
	by d01relay06.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	r4V2Hoa446071952
	for <qemu-devel@nongnu.org>; Thu, 30 May 2013 22:17:50 -0400
Received: from d01av02.pok.ibm.com (loopback [127.0.0.1])
	by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	r4V2HosS025124
	for <qemu-devel@nongnu.org>; Thu, 30 May 2013 23:17:50 -0300
Message-ID: <51A8084C.3010505@linux.vnet.ibm.com>
Date: Fri, 31 May 2013 10:17:48 +0800
From: Dongxu Wang <wdongxu@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <51A72673.7090300@linux.vnet.ibm.com> <51A74210.3000302@redhat.com>
	<20130530124830.GA6169@stefanha-thinkpad.redhat.com>
In-Reply-To: <20130530124830.GA6169@stefanha-thinkpad.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC] Check backing_file chain's loop
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: "kwolf@redhat.com" <kwolf@redhat.com>, qemu-devel@nongnu.org, stefanha@redhat.com

On 2013/5/30 20:48, Stefan Hajnoczi wrote:
>> hain 1.qcow2' don't crash.
> qemu-img info --backing-chain detects cycles and returns an error, see
> the hash table in collect_image_info_list().
>
> We should protect bdrv_open() too.
>
Okay, will send a patch.
> Stefan
>
>