From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33538) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiExm-0001c1-GE for qemu-devel@nongnu.org; Thu, 30 May 2013 22:21:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UiExl-0000Q8-96 for qemu-devel@nongnu.org; Thu, 30 May 2013 22:21:06 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:38102) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiExl-0000Q4-5O for qemu-devel@nongnu.org; Thu, 30 May 2013 22:21:05 -0400 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 30 May 2013 22:21:04 -0400 Received: from d01relay07.pok.ibm.com (d01relay07.pok.ibm.com [9.56.227.147]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id B67476E8040 for ; Thu, 30 May 2013 22:20:58 -0400 (EDT) Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay07.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r4V2L2Rv63439064 for ; Thu, 30 May 2013 22:21:02 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r4V2L1t3004161 for ; Thu, 30 May 2013 23:21:01 -0300 Message-ID: <51A8090C.9070203@linux.vnet.ibm.com> Date: Fri, 31 May 2013 10:21:00 +0800 From: Dongxu Wang MIME-Version: 1.0 References: <1369907728-4175-1-git-send-email-wdongxu@linux.vnet.ibm.com> <1369907728-4175-2-git-send-email-wdongxu@linux.vnet.ibm.com> <51A7C32E.5090208@redhat.com> In-Reply-To: <51A7C32E.5090208@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V15 1/6] add def_value_str in QemuOptDesc struct and rewrite qemu_opts_print List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, armbru@redhat.com On 2013/5/31 5:22, Eric Blake wrote: > On 05/30/2013 03:55 AM, Dongxu Wang wrote: >> From: Dong Xu Wang >> >> qemu_opts_print has no user now, so can re-write the function safely. >> >> qemu_opts_print will be used while using "qemu-img create", it will >> produce the same output as previous code. >> >> The behavior of this function has changed: >> >> 1. Print every possible option, whether a value has been set or not. >> 2. Option descriptors may provide a default value. >> 3. Print to stdout instead of stderr. >> >> Previously the behavior was to print every option that has been set. >> Options that have not been set would be skipped. > > Up to here is fine. > >> >> v13->v14: >> 1) fix memory leak. >> 2) make opt_set do not accpet null value argument. >> >> v12->v13 >> 1) re-write commit message. >> >> v11->v12 >> 1) make def_value_str become the real default value string in opt_set >> function. >> >> v10->v11: >> 1) print all values that have actually been assigned while accept-any >> cases. >> >> v7->v8: >> 1) print "elements => accept any params" while opts_accepts_any() == >> true. >> 2) since def_print_str is the default value if an option isn't set, >> so rename it to def_value_str. > > However, this chunk should be moved to appear after the '---' separator; > it's useful during review, but does not need to be part of qemu.git. > Okay. >> >> Signed-off-by: Dong Xu Wang >> Signed-off-by: Dongxu Wang > > And this looks fishy, having two S-o-B with slightly different spellings > of your name. Pick one and stick with it. > Ah.. sorry, my mistake.. >> --- > > Here is where patch changelogs go. For more hints, see > http://wiki.qemu.org/Contribute/SubmitAPatch > >> include/qemu/option.h | 3 ++- >> util/qemu-option.c | 32 ++++++++++++++++++++++++++------ >> 2 files changed, 28 insertions(+), 7 deletions(-) >> >> diff --git a/include/qemu/option.h b/include/qemu/option.h >> index bdb6d21..b928ab0 100644 >> --- a/include/qemu/option.h >> +++ b/include/qemu/option.h >> @@ -96,6 +96,7 @@ typedef struct QemuOptDesc { >> const char *name; >> enum QemuOptType type; >> const char *help; >> + const char *def_value_str; >> } QemuOptDesc; > > Now that we have the 'query-command-line-options' QMP command, I think > it's worth expanding that command to expose the default value of an > option, when one is given. It's probably content for a separate patch > (util/qemu-config.c:query_option_descs() and qapi-schema.json), but > still belongs as part of this series. > > Reviewed-by: Eric Blake >