From: Paolo Bonzini <pbonzini@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
qemu-devel@nongnu.org, edgar.iglesias@gmail.com
Subject: Re: [Qemu-devel] [PATCH v2 1/1] configure: dtc: Probe for libfdt_env.h
Date: Fri, 31 May 2013 10:25:55 +0200 [thread overview]
Message-ID: <51A85E93.5010507@redhat.com> (raw)
In-Reply-To: <20130531033245.GB5408@boomeroo.fritz.box>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Il 31/05/2013 05:32, David Gibson ha scritto:
>>> Then again, although we certainly want to keep changes which
>>> require updates to libfdt_env.h rare, I'm not going to rule
>>> out extensions to libfdt which add new (minor) external
>>> dependencies, and therefore changes to libfdt_env.h.
>>>
>>> That said, I did put my correction a bit too strongly. While
>>> libfdt_env.h is notionally always provided by the surrounding
>>> environment, if the packaged one works for your environment,
>>> it's probably a good idea to use it.
>>
>> I think we should be able to consider QEMU as normal enough to
>> use prepacked DTC and just fix the commit message?
>
> I concur.
Please don't. Fedora is not going to use the bundled dtc because of a
policy against bundling, and Fedora's dtc package doesn't include
libfdt_env.h.
If David says that the changes are rare enough, let's just fix the
bundled libfdt_env.h.
Paolo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJRqF6TAAoJEBvWZb6bTYbycyYQAJswKGTnYtac7eJb2s7+I48R
TwX8NDbsLXyuyrBRNtwK/yLuSIdXKZeyhXmJNWHtvf2KH0aSgP3+FKHnoOrc0m/U
7ZMfIqquDkqx0AspSIeEmp3Q+i03oyI+nRzop9tpyBAPDGQm6VsAJzggwEBjfAUJ
+Ww+1g4UTfF/9Nwjj9EMryS85gMQLwd52t2mIcxcEN22XucZbuF6OmFOk4Tt7EW1
ZbBMm+J8vFOFu77ejpRE03SsfN6vd2FDFgyo+nTGay89hlVKxUbSkmxsmVqcwpqb
rV9fk5r266+50SW5X/EzJLAyVtilXZSDB84wSRQFVP8vUKKGwxz1q56rEpuwfdBW
JYB69woigiC4RmYtgueGy2tnP5xSTXKopo5QjKyjcyJlqpF1xQEd8YVh5gKBYKxG
Hla2uEM/QOmMFR0jf9kj0kyIF2seK7PGMA3M+W5OFyB1YKWaVJIjFW/r13g8Zfjb
MkA2LirNWzLo5H/mgkYLrC2sa9e6zVbc7+IPgj7t0mIBOQN1L4V50n81xlQNalGq
/NGuyz7v3qbtQVCKbS2C+Jtoq2/uvHyY0jd7AytRRRCO9KA/mine1gpXX96T9PXB
kjJO3ASHEJLT8GblsFDtb9NWHKoO/jrUOWuKM/4OmL4aFdSTYY3+z3/+5PlJhhWY
jPFsbspFp+aEqJPox3kT
=znA9
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2013-05-31 8:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-27 4:20 [Qemu-devel] [PATCH v2 1/1] configure: dtc: Probe for libfdt_env.h peter.crosthwaite
2013-05-29 8:18 ` David Gibson
2013-05-29 9:14 ` Peter Maydell
2013-05-29 9:31 ` David Gibson
2013-05-31 1:48 ` Peter Crosthwaite
2013-05-31 3:32 ` David Gibson
2013-05-31 8:25 ` Paolo Bonzini [this message]
2013-05-31 9:44 ` Peter Maydell
2013-05-31 9:54 ` Paolo Bonzini
2013-05-31 12:37 ` Peter Crosthwaite
2013-06-01 5:38 ` David Gibson
2013-06-01 23:13 ` Peter Crosthwaite
2013-06-07 2:54 ` Peter Crosthwaite
2013-06-07 8:32 ` Peter Maydell
2013-06-01 5:22 ` David Gibson
2013-06-01 8:26 ` Peter Maydell
2013-06-01 23:09 ` Peter Crosthwaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A85E93.5010507@redhat.com \
--to=pbonzini@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=edgar.iglesias@gmail.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).