From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35452) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiKf2-0002oC-Mv for qemu-devel@nongnu.org; Fri, 31 May 2013 04:26:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UiKf1-0006Qn-Ky for qemu-devel@nongnu.org; Fri, 31 May 2013 04:26:08 -0400 Received: from mail-ea0-x231.google.com ([2a00:1450:4013:c01::231]:49386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiKf1-0006Qi-EG for qemu-devel@nongnu.org; Fri, 31 May 2013 04:26:07 -0400 Received: by mail-ea0-f177.google.com with SMTP id q14so1276912eaj.36 for ; Fri, 31 May 2013 01:26:06 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <51A85E93.5010507@redhat.com> Date: Fri, 31 May 2013 10:25:55 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <9b6a3a52e3f46cfbc1ded9ab56385ec045e46705.1369628289.git.peter.crosthwaite@xilinx.com> <20130529081853.GC5489@boomeroo.fritz.box> <20130529093157.GF5489@boomeroo.fritz.box> <20130531033245.GB5408@boomeroo.fritz.box> In-Reply-To: <20130531033245.GB5408@boomeroo.fritz.box> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/1] configure: dtc: Probe for libfdt_env.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: Peter Maydell , Peter Crosthwaite , qemu-devel@nongnu.org, edgar.iglesias@gmail.com -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Il 31/05/2013 05:32, David Gibson ha scritto: >>> Then again, although we certainly want to keep changes which >>> require updates to libfdt_env.h rare, I'm not going to rule >>> out extensions to libfdt which add new (minor) external >>> dependencies, and therefore changes to libfdt_env.h. >>> >>> That said, I did put my correction a bit too strongly. While >>> libfdt_env.h is notionally always provided by the surrounding >>> environment, if the packaged one works for your environment, >>> it's probably a good idea to use it. >> >> I think we should be able to consider QEMU as normal enough to >> use prepacked DTC and just fix the commit message? > > I concur. Please don't. Fedora is not going to use the bundled dtc because of a policy against bundling, and Fedora's dtc package doesn't include libfdt_env.h. If David says that the changes are rare enough, let's just fix the bundled libfdt_env.h. Paolo -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRqF6TAAoJEBvWZb6bTYbycyYQAJswKGTnYtac7eJb2s7+I48R TwX8NDbsLXyuyrBRNtwK/yLuSIdXKZeyhXmJNWHtvf2KH0aSgP3+FKHnoOrc0m/U 7ZMfIqquDkqx0AspSIeEmp3Q+i03oyI+nRzop9tpyBAPDGQm6VsAJzggwEBjfAUJ +Ww+1g4UTfF/9Nwjj9EMryS85gMQLwd52t2mIcxcEN22XucZbuF6OmFOk4Tt7EW1 ZbBMm+J8vFOFu77ejpRE03SsfN6vd2FDFgyo+nTGay89hlVKxUbSkmxsmVqcwpqb rV9fk5r266+50SW5X/EzJLAyVtilXZSDB84wSRQFVP8vUKKGwxz1q56rEpuwfdBW JYB69woigiC4RmYtgueGy2tnP5xSTXKopo5QjKyjcyJlqpF1xQEd8YVh5gKBYKxG Hla2uEM/QOmMFR0jf9kj0kyIF2seK7PGMA3M+W5OFyB1YKWaVJIjFW/r13g8Zfjb MkA2LirNWzLo5H/mgkYLrC2sa9e6zVbc7+IPgj7t0mIBOQN1L4V50n81xlQNalGq /NGuyz7v3qbtQVCKbS2C+Jtoq2/uvHyY0jd7AytRRRCO9KA/mine1gpXX96T9PXB kjJO3ASHEJLT8GblsFDtb9NWHKoO/jrUOWuKM/4OmL4aFdSTYY3+z3/+5PlJhhWY jPFsbspFp+aEqJPox3kT =znA9 -----END PGP SIGNATURE-----