From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60612) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiMY3-0001Wc-N3 for qemu-devel@nongnu.org; Fri, 31 May 2013 06:27:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UiMY2-0005FM-Gk for qemu-devel@nongnu.org; Fri, 31 May 2013 06:27:03 -0400 Sender: Paolo Bonzini Message-ID: <51A87AE6.8050502@redhat.com> Date: Fri, 31 May 2013 12:26:46 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1367545092-19980-1-git-send-email-david@gibson.dropbear.id.au> <1367545092-19980-8-git-send-email-david@gibson.dropbear.id.au> <51875DA7.4090308@redhat.com> <51A301AC.8070101@ozlabs.ru> <51A30528.9020708@redhat.com> <51A83C18.2030102@ozlabs.ru> <51A85CEE.4090409@redhat.com> <51A87799.1020304@ozlabs.ru> In-Reply-To: <51A87799.1020304@ozlabs.ru> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: agraf@suse.de, quintela@redhat.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, David Gibson Il 31/05/2013 12:12, Alexey Kardashevskiy ha scritto: > On 05/31/2013 06:18 PM, Paolo Bonzini wrote: >> Il 31/05/2013 07:58, Alexey Kardashevskiy ha scritto: >>> On 05/27/2013 05:03 PM, Paolo Bonzini wrote: >>>> Il 27/05/2013 08:48, Alexey Kardashevskiy ha scritto: >>>>>>> >>>>>>> This is only true when the rerror and werror options have the values >>>>>>> "ignore" or "report". See virtio-scsi for an example of how to save the >>>>>>> requests using the save_request and load_request callbacks in SCSIBusInfo. >>>>> >>>>> Sigh. >>>> >>>> ? >>> >>> I thought the series is ready to go but I was wrong. Furthermore when I got >>> to the point where I could actually test the save/restore for vscsi_req, >>> migration was totally broken on PPC and it took some time to fix it :-/ >> >> It is ready. I was just pointing out that it's not _production_ ready. > > What is the difference then? :) It is mergeable, but it needs further work and you should be aware of that. >>> How do you trigger the situation when there are inactive requests which >>> have to be migrated? >> >> You need to trigger an error. For example, you could use a sparse image >> on an almost-full partition and let "dd" fill your disk. Then migrate >> to another instance of QEMU on the same machine, the destination machine >> should succeed migration but fail starting the machine. > > Why would it fail? I run "dd", it fills the disk and stops. You have to make it fill the _host_ disk before it fills the guest disk. That's why I mentioned a sparse image. Then the machine pauses with the failing request in its queue. When you migrate, the request is migrated as well. Paolo