From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39339) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiP0v-0001nY-7s for qemu-devel@nongnu.org; Fri, 31 May 2013 09:05:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UiP0q-0003Kc-If for qemu-devel@nongnu.org; Fri, 31 May 2013 09:05:01 -0400 Received: from e28smtp07.in.ibm.com ([122.248.162.7]:50112) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiP0m-0003IF-Mr for qemu-devel@nongnu.org; Fri, 31 May 2013 09:04:56 -0400 Received: from /spool/local by e28smtp07.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 31 May 2013 18:28:24 +0530 Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id 1FFFD3940058 for ; Fri, 31 May 2013 18:34:37 +0530 (IST) Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r4VD4KTq10027116 for ; Fri, 31 May 2013 18:34:24 +0530 Received: from d28av03.in.ibm.com (loopback [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r4VD4QUP004173 for ; Fri, 31 May 2013 23:04:27 +1000 Message-ID: <51A89FCA.5080707@linux.vnet.ibm.com> Date: Fri, 31 May 2013 21:04:10 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1369451385-23452-1-git-send-email-xiawenc@linux.vnet.ibm.com> <20130527154139.GH2373@dhcp-200-207.str.redhat.com> <51A6BC41.7090803@linux.vnet.ibm.com> In-Reply-To: <51A6BC41.7090803@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V3 0/4] qapi and snapshot code clean up in block layer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: phrdina@redhat.com, stefanha@gmail.com, armbru@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, lcapitulino@redhat.com 于 2013-5-30 10:41, Wenchao Xia 写道: > 于 2013-5-27 23:41, Kevin Wolf 写道: >> Am 25.05.2013 um 05:09 hat Wenchao Xia geschrieben: >>> These patches are the common part of my hmp/qmp block query series >>> and Pavel's >>> qmp snapshot command converion series. It mainly does following things: >>> 1 move snapshot related code to block/snapshot.c, qmp and info >>> dumping code to >>> block/qapi.c. >>> 2 better info dumping function to get rid of buffer, avoid string >>> truncation. >> >> Posted comments on patch 1 and 4. >> >> Patches 2 and 3 are: >> Reviewed-by: Kevin Wolf >> > It seems nothing need change, Kevin, do you think it can be merged? > This serial blocks mine and Pavel's work, anything need to be improved? Respin with -typedef int (*fprintf_function)(FILE *f, const char *fmt, ...) +typedef int (*fprintf_function)(void *out, const char *fmt, ...) ? -- Best Regards Wenchao Xia