From: Richard Henderson <rth@twiddle.net>
To: Jani Kokkonen <Jani.Kokkonen@huawei.com>
Cc: Laurent Desnogues <laurent.desnogues@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>,
Claudio Fontana <claudio.fontana@huawei.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/4] tcg/aarch64: implement sign/zero extend operations
Date: Fri, 31 May 2013 12:13:52 -0700 [thread overview]
Message-ID: <51A8F670.1060601@twiddle.net> (raw)
In-Reply-To: <51A8E663.8020204@huawei.com>
On 05/31/2013 11:05 AM, Jani Kokkonen wrote:
> +static inline void tcg_out_uxt(TCGContext *s, int s_bits,
> + TCGReg rd, TCGReg rn)
> +{
> + /* using ALIASes UXTB 0x53001c00, UXTH 0x53003c00
> + of UBFM Wd, Wn, #0, #7|15 and mov */
> + int bits = 8 * (1 << s_bits) - 1;
> + tcg_out_ubfm(s, 0, rd, rn, 0, bits);
> +}
Err, ubfm never generates mov, does it?
Yes, you do that later,
> + case INDEX_op_ext32u_i64:
> + tcg_out_movr(s, 0, args[0], args[1]);
> + break;
but the comment isn't actually correct in tcg_out_uxt, surely?
r~
next prev parent reply other threads:[~2013-05-31 19:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 17:51 [Qemu-devel] [PATCH 0/4] ARM aarch64 TCG tlb fast lookup Jani Kokkonen
2013-05-31 17:57 ` [Qemu-devel] [PATCH 1/4] tcg/aarch64: more low level ops in preparation of tlb, lookup Jani Kokkonen
2013-05-31 19:07 ` Richard Henderson
2013-06-03 9:43 ` Claudio Fontana
2013-05-31 18:01 ` [Qemu-devel] [PATCH 2/4] tcg/aarch64: implement byte swap operations Jani Kokkonen
2013-05-31 19:11 ` Richard Henderson
2013-06-03 9:44 ` Claudio Fontana
2013-05-31 18:05 ` [Qemu-devel] [PATCH 3/4] tcg/aarch64: implement sign/zero extend operations Jani Kokkonen
2013-05-31 19:13 ` Richard Henderson [this message]
2013-06-03 9:48 ` Claudio Fontana
2013-05-31 18:07 ` [Qemu-devel] [PATCH 4/4] tcg/aarch64: implement tlb lookup fast path Jani Kokkonen
2013-05-31 20:25 ` Richard Henderson
2013-06-03 11:21 ` Jani Kokkonen
2013-06-03 15:52 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A8F670.1060601@twiddle.net \
--to=rth@twiddle.net \
--cc=Jani.Kokkonen@huawei.com \
--cc=claudio.fontana@huawei.com \
--cc=laurent.desnogues@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).