From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36825) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjKQZ-0005pJ-On for qemu-devel@nongnu.org; Sun, 02 Jun 2013 22:23:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UjKQW-0007fR-Vw for qemu-devel@nongnu.org; Sun, 02 Jun 2013 22:23:19 -0400 Received: from e28smtp06.in.ibm.com ([122.248.162.6]:41051) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjKQW-0007V6-A9 for qemu-devel@nongnu.org; Sun, 02 Jun 2013 22:23:16 -0400 Received: from /spool/local by e28smtp06.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 3 Jun 2013 07:46:08 +0530 Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id EBA3D394004F for ; Mon, 3 Jun 2013 07:52:48 +0530 (IST) Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r532Mgtj5832996 for ; Mon, 3 Jun 2013 07:52:42 +0530 Received: from d28av03.in.ibm.com (loopback [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r532MkEL010028 for ; Mon, 3 Jun 2013 12:22:46 +1000 Message-ID: <51ABFDDA.8080209@linux.vnet.ibm.com> Date: Mon, 03 Jun 2013 10:22:18 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1369451385-23452-1-git-send-email-xiawenc@linux.vnet.ibm.com> <20130527154139.GH2373@dhcp-200-207.str.redhat.com> <51A6BC41.7090803@linux.vnet.ibm.com> <51A89FCA.5080707@linux.vnet.ibm.com> <20130531091932.61d4cc03@redhat.com> In-Reply-To: <20130531091932.61d4cc03@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V3 0/4] qapi and snapshot code clean up in block layer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Kevin Wolf , phrdina@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com 于 2013-5-31 21:19, Luiz Capitulino 写道: > On Fri, 31 May 2013 21:04:10 +0800 > Wenchao Xia wrote: > >> 于 2013-5-30 10:41, Wenchao Xia 写道: >>> 于 2013-5-27 23:41, Kevin Wolf 写道: >>>> Am 25.05.2013 um 05:09 hat Wenchao Xia geschrieben: >>>>> These patches are the common part of my hmp/qmp block query series >>>>> and Pavel's >>>>> qmp snapshot command converion series. It mainly does following things: >>>>> 1 move snapshot related code to block/snapshot.c, qmp and info >>>>> dumping code to >>>>> block/qapi.c. >>>>> 2 better info dumping function to get rid of buffer, avoid string >>>>> truncation. >>>> >>>> Posted comments on patch 1 and 4. >>>> >>>> Patches 2 and 3 are: >>>> Reviewed-by: Kevin Wolf >>>> >>> It seems nothing need change, Kevin, do you think it can be merged? >>> >> This serial blocks mine and Pavel's work, anything need to be >> improved? Respin with >> -typedef int (*fprintf_function)(FILE *f, const char *fmt, ...) >> +typedef int (*fprintf_function)(void *out, const char *fmt, ...) >> ? > > As far as my review is concerned, I'm OK with your current version. > Thanks Luiz. This series does code moves, so it have big chance to get conflict when upstream changes, hope it not hang out too long... sorry for pushing many times. -- Best Regards Wenchao Xia