From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59889)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UjVna-0006Mo-Ia
	for qemu-devel@nongnu.org; Mon, 03 Jun 2013 10:31:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UjVnX-0005KW-TJ
	for qemu-devel@nongnu.org; Mon, 03 Jun 2013 10:31:50 -0400
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <51ACA8C5.10801@twiddle.net>
Date: Mon, 03 Jun 2013 07:31:33 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <20130602222452.1b0fdbd1@kryten> <20130602222827.620d5762@kryten>
In-Reply-To: <20130602222827.620d5762@kryten>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/4] tcg-ppc64: bswap64 rotates output 32
	bits
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anton Blanchard <anton@samba.org>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, agraf@suse.de, aurelien@aurel32.net, david@gibson.dropbear.id.au

On 06/02/2013 05:28 AM, Anton Blanchard wrote:
> If our input and output is in the same register, bswap64 tries to
> undo a rotate of the input. This just ends up rotating the output.
> 
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Anton Blanchard <anton@samba.org>

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~