From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32824)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UjX9o-00008I-Ol
	for qemu-devel@nongnu.org; Mon, 03 Jun 2013 11:58:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UjX9k-0005Ov-U7
	for qemu-devel@nongnu.org; Mon, 03 Jun 2013 11:58:52 -0400
Received: from mail-qc0-x22f.google.com ([2607:f8b0:400d:c01::22f]:64976)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UjX9k-0005Or-QC
	for qemu-devel@nongnu.org; Mon, 03 Jun 2013 11:58:48 -0400
Received: by mail-qc0-f175.google.com with SMTP id a1so2276803qcx.34
	for <qemu-devel@nongnu.org>; Mon, 03 Jun 2013 08:58:48 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <51ACBD31.70100@twiddle.net>
Date: Mon, 03 Jun 2013 08:58:41 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1370193044-24535-1-git-send-email-peter.maydell@linaro.org>
	<51ACB313.60007@twiddle.net>
	<CAFEAcA_n7hqrjSSH4X_P+QfC9PxztUEAwbJByFEXm_Tos7VE+g@mail.gmail.com>
In-Reply-To: <CAFEAcA_n7hqrjSSH4X_P+QfC9PxztUEAwbJByFEXm_Tos7VE+g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] linux-user: Allow getdents to be provided
 by getdents64
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Riku Voipio <riku.voipio@iki.fi>, Claudio Fontana <claudio.fontana@huawei.com>, qemu-devel@nongnu.org, patches@linaro.org

On 06/03/2013 08:45 AM, Peter Maydell wrote:
>>> >> +                    /* The target_dirent type is in what was formerly a padding
>>> >> +                     * byte at the end of the structure:
>>> >> +                     */
>>> >> +                    *(((char *)tde) + treclen - 1) = type;
>> >
>> > Maybe easier to read as
>> >
>> >   ((char *)tde)[treclen - 1] = type
>> >
>> > ?
> Dunno. It's not actually a char array, so I kind of prefer
> to use plain pointer arithmetic for this kind of thing.

Then drop the unnecessary parenthesis

  *((char *)tde + trelen - 1) = type;

?


r~