From: Eric Blake <eblake@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,
qemu-devel@nongnu.org, xiawenc@linux.vnet.ibm.com,
imain@redhat.com, Paolo Bonzini <pbonzini@redhat.com>,
dietmar@proxmox.com
Subject: Re: [Qemu-devel] [PATCH v5 04/11] blockdev: drop redundant proto_drv check
Date: Mon, 03 Jun 2013 11:14:31 -0600 [thread overview]
Message-ID: <51ACCEF7.4010508@redhat.com> (raw)
In-Reply-To: <1369917299-5725-5-git-send-email-stefanha@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 873 bytes --]
On 05/30/2013 06:34 AM, Stefan Hajnoczi wrote:
> It is not necessary to check that we can find a protocol block driver
> since we create or open the image file. This produces the error that we
> need anyway.
>
> Besides, the QERR_INVALID_BLOCK_FORMAT is inappropriate since the
> protocol is incorrect rather than the format.
>
> Also drop an empty line between bdrv_open() and checking its return
> value. This may be due to copy-pasting from earlier code that performed
> other operations before handling errors.
>
> Reported-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> blockdev.c | 15 ---------------
> 1 file changed, 15 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-06-03 17:14 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 12:34 [Qemu-devel] [PATCH v5 00/11] block: drive-backup live backup command Stefan Hajnoczi
2013-05-30 12:34 ` [Qemu-devel] [PATCH v5 01/11] notify: add NotiferWithReturn so notifier list can abort Stefan Hajnoczi
2013-05-30 22:27 ` Eric Blake
2013-06-03 9:11 ` Stefan Hajnoczi
2013-06-19 10:55 ` Kevin Wolf
2013-05-30 12:34 ` [Qemu-devel] [PATCH v5 02/11] block: add bdrv_add_before_write_notifier() Stefan Hajnoczi
2013-05-30 22:47 ` Eric Blake
2013-06-19 10:56 ` Kevin Wolf
2013-05-30 12:34 ` [Qemu-devel] [PATCH v5 03/11] block: add basic backup support to block driver Stefan Hajnoczi
2013-06-06 3:56 ` Fam Zheng
2013-06-06 8:05 ` Stefan Hajnoczi
2013-06-06 8:56 ` Fam Zheng
2013-06-07 7:18 ` Stefan Hajnoczi
2013-06-13 6:03 ` Wenchao Xia
2013-06-13 6:07 ` Wenchao Xia
2013-06-13 6:33 ` Fam Zheng
2013-06-13 8:02 ` Wenchao Xia
2013-06-13 8:51 ` Stefan Hajnoczi
2013-06-17 3:43 ` Fam Zheng
2013-06-17 12:36 ` Stefan Hajnoczi
2013-06-18 14:52 ` Kevin Wolf
2013-06-19 7:38 ` Stefan Hajnoczi
2013-06-19 10:50 ` Kevin Wolf
2013-06-19 11:14 ` Paolo Bonzini
2013-06-20 12:05 ` Stefan Hajnoczi
2013-06-19 11:19 ` Paolo Bonzini
2013-06-20 12:06 ` Stefan Hajnoczi
2013-06-20 12:11 ` Stefan Hajnoczi
2013-05-30 12:34 ` [Qemu-devel] [PATCH v5 04/11] blockdev: drop redundant proto_drv check Stefan Hajnoczi
2013-06-03 17:14 ` Eric Blake [this message]
2013-06-06 5:00 ` Wenchao Xia
2013-06-19 10:57 ` Kevin Wolf
2013-05-30 12:34 ` [Qemu-devel] [PATCH v5 05/11] blockdev: use bdrv_getlength() in qmp_drive_mirror() Stefan Hajnoczi
2013-05-30 13:24 ` Paolo Bonzini
2013-06-03 17:15 ` Eric Blake
2013-06-19 10:58 ` Kevin Wolf
2013-05-30 12:34 ` [Qemu-devel] [PATCH v5 06/11] block: add drive-backup QMP command Stefan Hajnoczi
2013-06-03 17:09 ` Eric Blake
2013-06-19 11:07 ` Kevin Wolf
2013-06-20 12:19 ` Stefan Hajnoczi
2013-06-20 13:15 ` Kevin Wolf
2013-05-30 12:34 ` [Qemu-devel] [PATCH v5 07/11] blockdev: rename BlkTransactionStates to singular Stefan Hajnoczi
2013-05-30 22:55 ` Eric Blake
2013-06-19 11:13 ` Kevin Wolf
2013-05-30 12:34 ` [Qemu-devel] [PATCH v5 08/11] blockdev: allow BdrvActionOps->commit() to be NULL Stefan Hajnoczi
2013-05-30 22:57 ` Eric Blake
2013-06-03 9:16 ` Stefan Hajnoczi
2013-06-19 11:14 ` Kevin Wolf
2013-05-30 12:34 ` [Qemu-devel] [PATCH v5 09/11] blockdev: add DriveBackup transaction Stefan Hajnoczi
2013-06-03 17:20 ` Eric Blake
2013-06-19 11:17 ` Kevin Wolf
2013-05-30 12:34 ` [Qemu-devel] [PATCH v5 10/11] blockdev: add Abort transaction Stefan Hajnoczi
2013-05-30 13:11 ` Eric Blake
2013-06-03 9:21 ` Stefan Hajnoczi
2013-06-19 11:21 ` Kevin Wolf
2013-06-21 9:31 ` Eric Blake
2013-05-30 12:34 ` [Qemu-devel] [PATCH v5 11/11] qemu-iotests: add 055 drive-backup test case Stefan Hajnoczi
2013-06-19 12:41 ` Kevin Wolf
2013-06-06 5:06 ` [Qemu-devel] [PATCH v5 00/11] block: drive-backup live backup command Wenchao Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51ACCEF7.4010508@redhat.com \
--to=eblake@redhat.com \
--cc=dietmar@proxmox.com \
--cc=famz@redhat.com \
--cc=imain@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).