From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55773) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjYL7-0003vZ-JT for qemu-devel@nongnu.org; Mon, 03 Jun 2013 13:14:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UjYL6-000439-3H for qemu-devel@nongnu.org; Mon, 03 Jun 2013 13:14:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6187) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjYL5-00042p-Ry for qemu-devel@nongnu.org; Mon, 03 Jun 2013 13:14:36 -0400 Message-ID: <51ACCEF7.4010508@redhat.com> Date: Mon, 03 Jun 2013 11:14:31 -0600 From: Eric Blake MIME-Version: 1.0 References: <1369917299-5725-1-git-send-email-stefanha@redhat.com> <1369917299-5725-5-git-send-email-stefanha@redhat.com> In-Reply-To: <1369917299-5725-5-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2MCFRJBTPSPBSJFRFTNNQ" Subject: Re: [Qemu-devel] [PATCH v5 04/11] blockdev: drop redundant proto_drv check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , Fam Zheng , qemu-devel@nongnu.org, xiawenc@linux.vnet.ibm.com, imain@redhat.com, Paolo Bonzini , dietmar@proxmox.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2MCFRJBTPSPBSJFRFTNNQ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/30/2013 06:34 AM, Stefan Hajnoczi wrote: > It is not necessary to check that we can find a protocol block driver > since we create or open the image file. This produces the error that w= e > need anyway. >=20 > Besides, the QERR_INVALID_BLOCK_FORMAT is inappropriate since the > protocol is incorrect rather than the format. >=20 > Also drop an empty line between bdrv_open() and checking its return > value. This may be due to copy-pasting from earlier code that performe= d > other operations before handling errors. >=20 > Reported-by: Kevin Wolf > Signed-off-by: Stefan Hajnoczi > --- > blockdev.c | 15 --------------- > 1 file changed, 15 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2MCFRJBTPSPBSJFRFTNNQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRrM73AAoJEKeha0olJ0NqeuwIAJZGVyb8lfgsaED6YjypRuSR aGueGGhIZ9ZT7sADDgnpRnLGcV56Zsh3kyrjQ8bbI6GhZwcPd05OM+vmO2yysfjJ Akjr5Mm+jPXZjE/13Iw54XFRNqRY9/xYxYcb7mlHZd0bCaWG9kKe+7MvK9ZX2G8a mQslvI2CUXK+lkQXao+jwm6JLW22i0rlEXIht4420jPl4ptsDYndthwvlwI9cntH M8J6w1Cd8Cys9aaJWJQvwsAsHOM5A5sbFpAkzu4IfPSyN5v0E2hmx/IbD3jNBgWJ 4AN9eHWQ9IiEHYOzqBvZDpIiIEw+K2nLt5doEWrlKUQAoWZSgTxKLI9cWZj0PDc= =Y3k0 -----END PGP SIGNATURE----- ------enig2MCFRJBTPSPBSJFRFTNNQ--