From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjYQr-0003MI-DN for qemu-devel@nongnu.org; Mon, 03 Jun 2013 13:20:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UjYQq-0006Ek-7C for qemu-devel@nongnu.org; Mon, 03 Jun 2013 13:20:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1817) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjYQp-0006Ec-T2 for qemu-devel@nongnu.org; Mon, 03 Jun 2013 13:20:32 -0400 Message-ID: <51ACD05A.2020305@redhat.com> Date: Mon, 03 Jun 2013 11:20:26 -0600 From: Eric Blake MIME-Version: 1.0 References: <1369917299-5725-1-git-send-email-stefanha@redhat.com> <1369917299-5725-10-git-send-email-stefanha@redhat.com> In-Reply-To: <1369917299-5725-10-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2CLCGGOAPBHHRHRXMGXAM" Subject: Re: [Qemu-devel] [PATCH v5 09/11] blockdev: add DriveBackup transaction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , Fam Zheng , qemu-devel@nongnu.org, xiawenc@linux.vnet.ibm.com, imain@redhat.com, Paolo Bonzini , dietmar@proxmox.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2CLCGGOAPBHHRHRXMGXAM Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/30/2013 06:34 AM, Stefan Hajnoczi wrote: > This patch adds a transactional version of the drive-backup QMP command= =2E > It allows atomic snapshots of multiple drives along with automatic > cleanup if there is a failure to start one of the backup jobs. >=20 > Note that QMP events are emitted for block job completion/cancellation > and the block job will be listed by query-block-jobs. >=20 >=20 > Signed-off-by: Stefan Hajnoczi > --- > blockdev.c | 49 ++++++++++++++++++++++++++++++++++++++++++++++++= + > qapi-schema.json | 40 +++++++++++++++++++++++++++++++++++++++- > 2 files changed, 88 insertions(+), 1 deletion(-) It would be nice if we could avoid copy-and-paste between the transaction and the self-standing command, perhaps by teaching the qapi code generator to recognize: { 'command': 'foo', 'data': 'DictType' } as shorthand for { 'command': 'foo', 'data': { ...inlined contents of DictType... } } But that is a cleanup that would apply to other existing qapi commands, and is therefore better done as an independent series, and therefore does not stop me from giving: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2CLCGGOAPBHHRHRXMGXAM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRrNBbAAoJEKeha0olJ0Nq0tQIAJib5KEEkWw8uleU1sR2Kdp/ gkVs5fPai0LPOsmsUWXuhuxeLs01YDI0zQXuojlzYq6VUw8KwnfepA17y/Mwu+7B Lu6oJIiN62byREYnR0DyeZ5RM5TXwxliZT1C8+/UzOh7VNWcI7xvFF1HIdMc1Jsf b94GMS2g/hWnljVEAZfLMDLztFE7B8a39XSnDHEHU2o+yxX6RL634E+CJUjrquU8 pEqIeU1vTm1yiro6G54KGyvJd1ugpVymqCo7Yac/2qOBqYqK6L7iB3BfL27UVPCg 7G23DXRgXWmOPcc6gKn8gK4FvoGaozt9u6DxZNGu3vpM4jT5UikduDkMTljvxjs= =Llhu -----END PGP SIGNATURE----- ------enig2CLCGGOAPBHHRHRXMGXAM--