From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49812) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ujbx7-0004tM-Gd for qemu-devel@nongnu.org; Mon, 03 Jun 2013 17:06:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UjbpG-0005TY-OL for qemu-devel@nongnu.org; Mon, 03 Jun 2013 16:58:25 -0400 Received: from mail-we0-x22e.google.com ([2a00:1450:400c:c03::22e]:36289) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjbpG-0005Sm-ET for qemu-devel@nongnu.org; Mon, 03 Jun 2013 16:57:58 -0400 Received: by mail-we0-f174.google.com with SMTP id q58so2225378wes.33 for ; Mon, 03 Jun 2013 13:57:57 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <51AD0348.2090707@redhat.com> Date: Mon, 03 Jun 2013 22:57:44 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1370272748-10629-1-git-send-email-pbonzini@redhat.com> <1370272748-10629-2-git-send-email-pbonzini@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/3] sysfw: remove read-only pc_sysfw_flash_vs_rom_bug_compatible List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jordan Justen Cc: Jordan Justen , qemu-devel , Markus Armbruster Il 03/06/2013 22:36, Jordan Justen ha scritto: > On Mon, Jun 3, 2013 at 8:19 AM, Paolo Bonzini wrote: >> The variable is not written anymore. >> >> Signed-off-by: Paolo Bonzini >> --- >> hw/block/pc_sysfw.c | 26 +------------------------- >> 1 file changed, 1 insertion(+), 25 deletions(-) >> >> diff --git a/hw/block/pc_sysfw.c b/hw/block/pc_sysfw.c >> index 412d1b0..c6d4be4 100644 >> --- a/hw/block/pc_sysfw.c >> +++ b/hw/block/pc_sysfw.c >> @@ -199,12 +199,6 @@ static void old_pc_system_rom_init(MemoryRegion *rom_memory, bool isapc_ram_fw) >> bios); >> } >> >> -/* >> - * Bug-compatible flash vs. ROM selection enabled? >> - * A few older machines enable this. >> - */ >> -bool pc_sysfw_flash_vs_rom_bug_compatible; > > Hmm. I think we still need this to retain the 1.2-1.5 compatible > behavior. But, I think I maybe my kvm readonly series didn't properly > resurrect the pc_sysfw_flash_vs_rom_bug_compatible switch. No, we shouldn't. It only worked with TCG, and it is simpler to just document to use -pflash (instead of -bios) to run OVMF. The misfeature was dropped (with this minor backwards incompatibility) on purpose. Paolo