From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43041)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Ujl7e-0002OY-7K
	for qemu-devel@nongnu.org; Tue, 04 Jun 2013 02:53:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Ujl7Y-0008FB-70
	for qemu-devel@nongnu.org; Tue, 04 Jun 2013 02:53:34 -0400
Received: from mail-wg0-x234.google.com ([2a00:1450:400c:c00::234]:36733)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Ujl7X-0008Ej-W9
	for qemu-devel@nongnu.org; Tue, 04 Jun 2013 02:53:28 -0400
Received: by mail-wg0-f52.google.com with SMTP id z11so3918489wgg.31
	for <qemu-devel@nongnu.org>; Mon, 03 Jun 2013 23:53:27 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <51AD8EDA.6060606@redhat.com>
Date: Tue, 04 Jun 2013 08:53:14 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <CAFfJ-R6H95+O5N4phuO611R20hEO6CoT27VAWwoU=6oq5jiRwA@mail.gmail.com>
	<51AC3A14.5020602@redhat.com>
	<CAFfJ-R5va8RKiYQz2oKH3+cK-Gg1Ps6TB9C7DuoOqOYm1AMOyw@mail.gmail.com>
	<CAFfJ-R6KngbEiuGXDSrAyFM0H8VmaRB4s=NWgB_N5k+bqb_xSg@mail.gmail.com>
In-Reply-To: <CAFfJ-R6KngbEiuGXDSrAyFM0H8VmaRB4s=NWgB_N5k+bqb_xSg@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] fstrim and cache=none
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dusty Mabe <dustymabe@gmail.com>
Cc: qemu-devel@nongnu.org

Il 04/06/2013 03:02, Dusty Mabe ha scritto:
> On Mon, Jun 3, 2013 at 5:39 PM, Dusty Mabe <dustymabe@gmail.com> wrote:
>>
>> It is possible that I was mistaken. Now when I switch back to
>> cache=none I am still able to execute trim operations. I'll
>> investigate a little more into my exact steps that I took and see if I
>> can come up with a reproducer for the issue I observed.
>>
> 
> Paolo,
> 
> I was mistaken. I had added a disk to the guest and then created an
> ext4 FS on the disk. I then noticed that I couldn't perform fstrim
> operations. I then examined the xml and the only difference between
> this disk and the other disk in the system was the cache=none. So I
> removed cache=none and then shutdown/booted the guest. After the
> reboot all worked fine so I assumed it was the cache=none line. This
> was wrong.
> 
> Actually it is the formatting of the filesystem. When i create an FS
> in the guest it disables discard. There are also some errors printed
> in /var/log/messages.
> 
> Please see the output in file at the following location:
> 
> http://dustymabe.com/content/qemu-devel-mail.txt

Please attach the QEMU command line too.  I'll try to reproduce.

Paolo