From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] sysfw: remove read-only pc_sysfw_flash_vs_rom_bug_compatible
Date: Tue, 04 Jun 2013 11:43:22 +0200 [thread overview]
Message-ID: <51ADB6BA.9050402@redhat.com> (raw)
In-Reply-To: <87y5aqutjr.fsf@blackfin.pond.sub.org>
Il 04/06/2013 11:14, Markus Armbruster ha scritto:
>> > The variable is not written anymore.
> This cleans up after 9e1c2ec (which accidentally left variable
> pc_sysfw_flash_vs_rom_bug_compatible behind, value always zero), and
> buries dead code from commit dafb82e (which looks like it got confused
> by pc_sysfw_flash_vs_rom_bug_compatible). Suggest to mention that in
> the commit message.
To be honest I didn't check it that thoroughly---I was just rebasing old
patches. I'll respin immediately since it only changes the commit message.
Paolo
next prev parent reply other threads:[~2013-06-04 9:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 15:19 [Qemu-devel] [PATCH 0/3] Remove legacy sysfw code Paolo Bonzini
2013-06-03 15:19 ` [Qemu-devel] [PATCH 1/3] sysfw: remove read-only pc_sysfw_flash_vs_rom_bug_compatible Paolo Bonzini
2013-06-03 20:36 ` Jordan Justen
2013-06-03 20:57 ` Paolo Bonzini
2013-06-04 9:17 ` Markus Armbruster
2013-06-04 9:14 ` Markus Armbruster
2013-06-04 9:43 ` Paolo Bonzini [this message]
2013-06-03 15:19 ` [Qemu-devel] [PATCH 2/3] pc_sysfw: remove the rom_only property Paolo Bonzini
2013-06-03 20:50 ` Jordan Justen
2013-06-03 21:00 ` Paolo Bonzini
2013-06-03 15:19 ` [Qemu-devel] [PATCH 3/3] pc_sysfw: do not make it a device anymore Paolo Bonzini
2013-06-03 20:46 ` Jordan Justen
2013-06-03 21:00 ` Paolo Bonzini
2013-06-03 21:56 ` [Qemu-devel] [PATCH 0/3] Remove legacy sysfw code Jordan Justen
2013-06-04 6:46 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51ADB6BA.9050402@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=jordan.l.justen@intel.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).