From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjnmF-0003VE-JI for qemu-devel@nongnu.org; Tue, 04 Jun 2013 05:43:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UjnmD-0001I4-Ce for qemu-devel@nongnu.org; Tue, 04 Jun 2013 05:43:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29491) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjnmD-0001HR-5z for qemu-devel@nongnu.org; Tue, 04 Jun 2013 05:43:37 -0400 Message-ID: <51ADB6BA.9050402@redhat.com> Date: Tue, 04 Jun 2013 11:43:22 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1370272748-10629-1-git-send-email-pbonzini@redhat.com> <1370272748-10629-2-git-send-email-pbonzini@redhat.com> <87y5aqutjr.fsf@blackfin.pond.sub.org> In-Reply-To: <87y5aqutjr.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/3] sysfw: remove read-only pc_sysfw_flash_vs_rom_bug_compatible List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Jordan Justen , qemu-devel@nongnu.org Il 04/06/2013 11:14, Markus Armbruster ha scritto: >> > The variable is not written anymore. > This cleans up after 9e1c2ec (which accidentally left variable > pc_sysfw_flash_vs_rom_bug_compatible behind, value always zero), and > buries dead code from commit dafb82e (which looks like it got confused > by pc_sysfw_flash_vs_rom_bug_compatible). Suggest to mention that in > the commit message. To be honest I didn't check it that thoroughly---I was just rebasing old patches. I'll respin immediately since it only changes the commit message. Paolo