From: Paolo Bonzini <bonzini@gnu.org>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Dmitry Fleytman <dmitry@daynix.com>,
qemu-devel@nongnu.org, "1.5.x" <qemu-stable@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] vmxnet3: fix NICState cleanup
Date: Tue, 04 Jun 2013 14:57:52 +0200 [thread overview]
Message-ID: <51ADE450.8010001@gnu.org> (raw)
In-Reply-To: <1370350046-14283-1-git-send-email-stefanha@redhat.com>
Il 04/06/2013 14:47, Stefan Hajnoczi ha scritto:
> Use qemu_del_nic() instead of qemu_del_net_client() to correctly free
> the entire NICState.
>
> Reported-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-stable@nongnu.org
> ---
> hw/net/vmxnet3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
> index 5f483e7..4c575e5 100644
> --- a/hw/net/vmxnet3.c
> +++ b/hw/net/vmxnet3.c
> @@ -1892,7 +1892,7 @@ static void vmxnet3_net_uninit(VMXNET3State *s)
> vmxnet_tx_pkt_reset(s->tx_pkt);
> vmxnet_tx_pkt_uninit(s->tx_pkt);
> vmxnet_rx_pkt_uninit(s->rx_pkt);
> - qemu_del_net_client(qemu_get_queue(s->nic));
> + qemu_del_nic(s->nic);
> }
>
> static void vmxnet3_net_init(VMXNET3State *s)
>
next prev parent reply other threads:[~2013-06-04 12:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 12:47 [Qemu-devel] [PATCH] vmxnet3: fix NICState cleanup Stefan Hajnoczi
2013-06-04 12:57 ` Paolo Bonzini [this message]
2013-06-04 13:18 ` Dmitry Fleytman
2013-06-05 8:35 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51ADE450.8010001@gnu.org \
--to=bonzini@gnu.org \
--cc=dmitry@daynix.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).