From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51798)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UjqoX-00060g-W4
	for qemu-devel@nongnu.org; Tue, 04 Jun 2013 08:58:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UjqoS-0003IT-PL
	for qemu-devel@nongnu.org; Tue, 04 Jun 2013 08:58:13 -0400
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <51ADE450.8010001@gnu.org>
Date: Tue, 04 Jun 2013 14:57:52 +0200
From: Paolo Bonzini <bonzini@gnu.org>
MIME-Version: 1.0
References: <1370350046-14283-1-git-send-email-stefanha@redhat.com>
In-Reply-To: <1370350046-14283-1-git-send-email-stefanha@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] vmxnet3: fix NICState cleanup
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Dmitry Fleytman <dmitry@daynix.com>, qemu-devel@nongnu.org, "1.5.x" <qemu-stable@nongnu.org>

Il 04/06/2013 14:47, Stefan Hajnoczi ha scritto:
> Use qemu_del_nic() instead of qemu_del_net_client() to correctly free
> the entire NICState.
> 
> Reported-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

Cc: qemu-stable@nongnu.org

> ---
>  hw/net/vmxnet3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
> index 5f483e7..4c575e5 100644
> --- a/hw/net/vmxnet3.c
> +++ b/hw/net/vmxnet3.c
> @@ -1892,7 +1892,7 @@ static void vmxnet3_net_uninit(VMXNET3State *s)
>      vmxnet_tx_pkt_reset(s->tx_pkt);
>      vmxnet_tx_pkt_uninit(s->tx_pkt);
>      vmxnet_rx_pkt_uninit(s->rx_pkt);
> -    qemu_del_net_client(qemu_get_queue(s->nic));
> +    qemu_del_nic(s->nic);
>  }
>  
>  static void vmxnet3_net_init(VMXNET3State *s)
>