From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35145)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Ujsob-0005Y9-Hz
	for qemu-devel@nongnu.org; Tue, 04 Jun 2013 11:06:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UjsoV-0002au-47
	for qemu-devel@nongnu.org; Tue, 04 Jun 2013 11:06:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50328)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UjsoU-0002a6-Rw
	for qemu-devel@nongnu.org; Tue, 04 Jun 2013 11:06:19 -0400
Message-ID: <51AE025D.7090909@redhat.com>
Date: Tue, 04 Jun 2013 17:06:05 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1370348041-6768-1-git-send-email-pbonzini@redhat.com>
	<1370348041-6768-7-git-send-email-pbonzini@redhat.com>
	<CAFEAcA-9+KyT09j3V5iggWzT2eVN4+8x1wpFZc-FD5mLjq=eQw@mail.gmail.com>
	<51ADDE1A.4030709@redhat.com>
	<CAFEAcA_rndDRq4=9rA0mnKdD0YMevyOS2sac3zub1+WyjudPMw@mail.gmail.com>
	<51ADEAA6.2050509@redhat.com>
	<CAFEAcA9RxY0T=UUvhxhAOyAHzq3cX_wyOUcPy=OYuswAK_ROdQ@mail.gmail.com>
	<51ADF960.9030208@redhat.com>
	<CAFEAcA8q5TyWaGwB98OqqyGKadaObY-eLU2S+dOX2Sb9D3jQTA@mail.gmail.com>
In-Reply-To: <CAFEAcA8q5TyWaGwB98OqqyGKadaObY-eLU2S+dOX2Sb9D3jQTA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 06/17] sysbus: add sysbus_pass_mmio
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org

Il 04/06/2013 16:56, Peter Maydell ha scritto:
>>> As a concrete example, if somebody submitted cirrus_vga
>>> as a new driver, I have no idea how to tell that it needs
>>> to set the owner for its memory regions, when 99% of
>>> other devices don't. I think this is going to result in
>>> "forgot to set owner" bugs.
>>
>> Because cirrus is adding regions directly to address_space_memory/io.
>> As documented:
>>
>>  * The device must set the owner itself
>>  * only if it uses memory_region_add_subregion directly on some address
>>  * space, or after the parent region is passed to the bus (for example
>>  * dynamically while the device runs).
> 
> OK, so why doesn't your patchset make the places in
> hw/arm/omap1.c which add memory regions directly
> to a subregion set the owner of the region?

Because these aren't qdevified.

> (or any of the many other places where we do similar things).

Note that it's only necessary to do so when you add those to the address
space, not to other regions.

Paolo