From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkAMw-0007t7-2E for qemu-devel@nongnu.org; Wed, 05 Jun 2013 05:51:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UkAMr-0003m5-II for qemu-devel@nongnu.org; Wed, 05 Jun 2013 05:51:01 -0400 Received: from cantor2.suse.de ([195.135.220.15]:50654 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkAMr-0003lx-Be for qemu-devel@nongnu.org; Wed, 05 Jun 2013 05:50:57 -0400 Message-ID: <51AF09FC.50308@suse.de> Date: Wed, 05 Jun 2013 11:50:52 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1370371954-8479-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1370371954-8479-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, mst@redhat.com Am 04.06.2013 20:51, schrieb Paolo Bonzini: > This series changes all PCI devices (the sole to support hotplug > _and_ use MemoryRegions) to do memory_region_del_subregion at > unrealize time, and memory_region_destroy at instance_finalize > time. The general idea looks good. Could you please follow-up with a patch that switches from exit to unrealize? Also I notice some patches are accessing parent fields directly - please use BUS(), PCI_DEVICE() etc. to hide this. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg