From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37716)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1UkBib-0008DJ-CE
	for qemu-devel@nongnu.org; Wed, 05 Jun 2013 07:17:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1UkBiZ-0006qw-PJ
	for qemu-devel@nongnu.org; Wed, 05 Jun 2013 07:17:29 -0400
Received: from mail-pb0-x22b.google.com ([2607:f8b0:400e:c01::22b]:41502)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1UkBiZ-0006q6-Il
	for qemu-devel@nongnu.org; Wed, 05 Jun 2013 07:17:27 -0400
Received: by mail-pb0-f43.google.com with SMTP id md12so568494pbc.16
	for <qemu-devel@nongnu.org>; Wed, 05 Jun 2013 04:17:26 -0700 (PDT)
Message-ID: <51AF1E41.4010109@ozlabs.ru>
Date: Wed, 05 Jun 2013 21:17:21 +1000
From: Alexey Kardashevskiy <aik@ozlabs.ru>
MIME-Version: 1.0
References: <1370348465-31652-1-git-send-email-aik@ozlabs.ru>
	<1370348465-31652-5-git-send-email-aik@ozlabs.ru>
	<51AEAEDA.2000304@ozlabs.ru>
	<20130605095522.GD19511@voom.bne.redhat.com>
In-Reply-To: <20130605095522.GD19511@voom.bne.redhat.com>
Content-Type: text/plain; charset=KOI8-R
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 04/13] pseries: savevm support for XICS
	interrupt controller
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Paul Mackerras <paulus@samba.org>, Alexander Graf <agraf@suse.de>

On 05.06.2013 19:55, David Gibson wrote:
> On Wed, Jun 05, 2013 at 01:22:02PM +1000, Alexey Kardashevskiy wrote:
>> On 06/04/2013 10:20 PM, Alexey Kardashevskiy wrote:
> [snip]
>>> +static int ics_post_load(void *opaque, int version_id)
>>> +{
>>> +    int i;
>>> +    struct ics_state *ics = opaque;
>>> +
>>> +    for (i = 0; i < ics->nr_irqs; i++) {
>>
>> Obviously here is a bug...
>>
>> -    for (i = 0; i < ics->nr_irqs; i++) {
>> +    for (i = 0; i < ics->icp->nr_servers; i++) {
> 
> Ah.. yes.  Although it would be a little nicer to avoid the duplicate
> calls to ics_resend() that will cause.  Still the simple version
> should be correct for now.  Please resend with this fixed.

I'll wait till Friday (do we expect anyone to comment, besides you?) and
repost the whole series with fixed "from" :)


-- 
With best regards

Alexey Kardashevskiy -- icq: 52150396