From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37438) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkD7R-0001q1-04 for qemu-devel@nongnu.org; Wed, 05 Jun 2013 08:47:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UkD7P-0005PU-Se for qemu-devel@nongnu.org; Wed, 05 Jun 2013 08:47:12 -0400 Received: from cantor2.suse.de ([195.135.220.15]:60954 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkD7P-0005PM-LI for qemu-devel@nongnu.org; Wed, 05 Jun 2013 08:47:11 -0400 Message-ID: <51AF334C.3060505@suse.de> Date: Wed, 05 Jun 2013 14:47:08 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1370371954-8479-1-git-send-email-pbonzini@redhat.com> <51AF09FC.50308@suse.de> <20130605111044.GL31830@redhat.com> <51AF21C1.3060503@suse.de> <20130605120656.GC2643@redhat.com> <51AF2DA7.1060605@suse.de> <20130605123644.GA3638@redhat.com> In-Reply-To: <20130605123644.GA3638@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Paolo Bonzini , qemu-devel@nongnu.org, Anthony Liguori , Jesse Larrew Am 05.06.2013 14:36, schrieb Michael S. Tsirkin: >> Anyway, my point was, when moving stuff out of exit, we should also >> change the signature to the new one - DeviceState* and (unused) Error*= *. >> Then we're getting closer to removing the old exit field, and at that >> point renaming individual hooks - if desired - becomes a trivial patch= . >=20 > Why is renaming new hooks related to getting rid of old ones? * less ambiguity and more names to choose from * introducing new callbacks as done here for instance_finalize requires care for variable names (PCIDevice *dev vs. DeviceState *dev is the classic) whereas renaming a hook once used is a trivial one-line change * renaming hooks now adds to the already existing confusion of a half-done conversion Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg