From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52600) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkDm5-0007lS-DK for qemu-devel@nongnu.org; Wed, 05 Jun 2013 09:29:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UkDm3-0004vU-R0 for qemu-devel@nongnu.org; Wed, 05 Jun 2013 09:29:13 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34524 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkDm3-0004vM-HJ for qemu-devel@nongnu.org; Wed, 05 Jun 2013 09:29:11 -0400 Message-ID: <51AF3D24.7050008@suse.de> Date: Wed, 05 Jun 2013 15:29:08 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1370438326-27054-1-git-send-email-imammedo@redhat.com> In-Reply-To: <1370438326-27054-1-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-cpu 00/15 v8] target-i386: convert CPU features into properties, part 1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, ehabkost@redhat.com Am 05.06.2013 15:18, schrieb Igor Mammedov: > It's a rebase of v7 on current qom-cpu tree, since then some patches fr= om it > were applied to master. Convertion of feature bits is left for part 2 > since it's not ready yet. >=20 > v7-v8: > * split out dynamic properties convertion patch into per property patch= es > to simplify review > * drop feature bits convertion Why is conversion of dynamic properties to static properties still needed after I applied a solution to override values of dynamic properties with -global for 1.5? For HyperV no doubt that the current state needs cleanups. Andreas >=20 > v6-v7: > * convert globals check_cpuid, enforce_cpuid and hyperv_* to fields of > CPUState > * Make PropertyInfo-s static > * maintain legacy kvmclock semantic in cpu_x86_parse_featurestr() > * existing properties code are not moved around, just fixed signatures = where > it's needed and used visitors.=20 >=20 > v5-v6: > * when converting feature names to property names, replace '_' with '-' > * separate patches converting existing dynamic properties into one, wer= e > squashed into one [1/9] and change tested with virt-test(next). > * patches that were touching +-foo features are squashed into one [9/9]= , > to avoid behavior change between them(f-kvmclock property). > * the rest of conversions were basicaly rebased on top of current qom-c= pu-next > tree, with small corrections >=20 > git for testing: https://github.com/imammedo/qemu/tree/x86-cpu-properti= es.v8 >=20 > Igor Mammedov (15): > target-i386: cpu: convert 'family' to static property > target-i386: cpu: convert 'model' to static property > target-i386: cpu: convert 'stepping' to static property > target-i386: cpu: convert 'level' to static property > target-i386: cpu: convert 'xlevel' to static property > target-i386: cpu: convert 'vendor' to static property > target-i386: cpu: convert 'model-id' to static property > target-i386: cpu: convert 'tsc-frequency' to static property > target-i386: move hyperv_* static globals to CPUState > target-i386: convert 'hv_spinlocks' to static property > target-i386: convert 'hv_relaxed' to static property > target-i386: convert 'hv_vapic' to static property > target-i386: convert 'check' and 'enforce' to static properties > target-i386: cleanup 'foo' feature handling' > target-i386: cleanup 'foo=3Dval' feature handling >=20 > target-i386/Makefile.objs | 2 +- > target-i386/cpu.c | 250 +++++++++++++++++++++++++++----------= -------- > target-i386/cpu.h | 9 ++ > target-i386/hyperv.c | 64 ------------ > target-i386/hyperv.h | 45 -------- > target-i386/kvm.c | 36 +++++-- > 6 files changed, 188 insertions(+), 218 deletions(-) > delete mode 100644 target-i386/hyperv.c > delete mode 100644 target-i386/hyperv.h >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg