From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42307) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkHX1-0003EJ-VQ for qemu-devel@nongnu.org; Wed, 05 Jun 2013 13:30:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UkHWw-0001SN-Vu for qemu-devel@nongnu.org; Wed, 05 Jun 2013 13:29:55 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47051 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkHWw-0001SH-MR for qemu-devel@nongnu.org; Wed, 05 Jun 2013 13:29:50 -0400 Message-ID: <51AF758A.2070404@suse.de> Date: Wed, 05 Jun 2013 19:29:46 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1370438326-27054-1-git-send-email-imammedo@redhat.com> <51AF3D24.7050008@suse.de> <20130605163917.35dda0ba@nial.usersys.redhat.com> <51AF6FBB.80802@suse.de> <20130605171740.GV2580@otherpad.lan.raisama.net> In-Reply-To: <20130605171740.GV2580@otherpad.lan.raisama.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-cpu 00/15 v8] target-i386: convert CPU features into properties, part 1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Peter Maydell , Jesse Larrew , qemu-devel@nongnu.org, Anthony Liguori , Paolo Bonzini , Igor Mammedov , =?ISO-8859-1?Q?KONRAD_Fr=E9d=E9ric?= Am 05.06.2013 19:17, schrieb Eduardo Habkost: > On Wed, Jun 05, 2013 at 07:04:59PM +0200, Andreas F=E4rber wrote: >> Am 05.06.2013 16:39, schrieb Igor Mammedov: >>> On Wed, 05 Jun 2013 15:29:08 +0200 >>> Andreas F=E4rber wrote: >>>> Why is conversion of dynamic properties to static properties still >>>> needed after I applied a solution to override values of dynamic >>>> properties with -global for 1.5? >>> Do you mean qdev_prop_set_globals_for_type() & co? >> >> Yes. >> >>> If yes, then I recall it was acceptable hack to permit more clean >>> approach for compat props fixes to work. And we promised Anthony to >>> get rid of it when possible. >> >> Indeed, but no one talked about reverting to static properties as the >> solution. :) Instead I was talking about solving this very general >> problem at DeviceState / QOM level. >=20 > We have had this discussion before, and I remember Anthony saying that > anything set using global properties _must_ be static properties, > period. Obviously I am not aware of that, might that have been an IRC discussion?= ! > That was the main motivation we even started doing the static propertie= s > work, months ago. Towards Paolo and me, Anthony rejected having static properties for QOM at all! That was back when I temporarily maintained a qom-next tree during some Hard Freeze, I had to unqueue patches to that effect. >> Instead we have a very generic problem: instance_init is called >> recursively, parents first, so a parent class cannot do any instance >> initialization *after* its derived classes initialized the instance. >> That's contrary to how realize and other QOM methods work but in >> exchange for the flexibility put the burden of saving and calling the >> parent's implementation onto subclasses. >> >> That's what I would like to change in some way, possibly a >> instance_post_init hook or the like, similar to how DeviceState got it= s >> own base class initialization hook to handle static props. >> That would not only keep the work low in this case but may also solve >> the virtio-net initialization problem reported elsewhere. >=20 > You mean this? > https://lists.gnu.org/archive/html/qemu-devel/2012-10/msg00434.html No, wasn't aware of that patchset yet, but yes, something like that I had suggested in the qdev_set_custom_globals() context last Soft Freeze. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg