From: Brad Smith <brad@comstyle.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-stable@nongnu.org, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-stable] [PATCH for 1.5] ui/gtk.c: Fix *BSD build of Gtk+ UI
Date: Wed, 05 Jun 2013 14:22:13 -0400 [thread overview]
Message-ID: <51AF81D5.3090701@comstyle.com> (raw)
In-Reply-To: <51A08113.6010903@msgid.tls.msk.ru>
On 25/05/13 5:14 AM, Michael Tokarev wrote:
> 24.05.2013 22:47, Brad Smith wrote:
>
>>>> +++ b/include/qemu-common.h
>>>> #elif defined CONFIG_BSD
>>>> +# include <termios.h>
>
>> Kinda late nit picking about it now.
>
> It's not. And it's not nitpicking really, we're
> carrying a ton of unnecessary #includes which slows
> down compilation significantly.
I agree.
> The whole this piece of #include twist was to get
> declaration of openpty() or equivalent. You just
> stiffed an unrelated #include into this piece which
> was okay to remove completely. I already removed
> it from several other .c files where it went from
> vl.c originally, which used to have chardev code
> which is now in another file.
It was not unrelated, it was necessary for the BSD
code path which utilizes openpty().
> What was the original issue? Where exactly it was
> failing? I mean, where's the _proper_ place to
> fix it?
It was failing in the Gtk+ UI code due to the use
of openpty().
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
next prev parent reply other threads:[~2013-06-05 18:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130522223817.GB14845@rox.home.comstyle.com>
[not found] ` <519E3091.2060402@msgid.tls.msk.ru>
[not found] ` <20130524184737.GA9642@rox.home.comstyle.com>
2013-05-25 9:14 ` [Qemu-devel] [Qemu-stable] [PATCH for 1.5] ui/gtk.c: Fix *BSD build of Gtk+ UI Michael Tokarev
2013-06-05 18:22 ` Brad Smith [this message]
2013-06-05 10:13 ` [Qemu-devel] [Qemu] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AF81D5.3090701@comstyle.com \
--to=brad@comstyle.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).