From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33144) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkIPe-0000Fg-Kz for qemu-devel@nongnu.org; Wed, 05 Jun 2013 14:26:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UkIPa-00066J-2s for qemu-devel@nongnu.org; Wed, 05 Jun 2013 14:26:22 -0400 Message-ID: <51AF81D5.3090701@comstyle.com> Date: Wed, 05 Jun 2013 14:22:13 -0400 From: Brad Smith MIME-Version: 1.0 References: <20130522223817.GB14845@rox.home.comstyle.com> <519E3091.2060402@msgid.tls.msk.ru> <20130524184737.GA9642@rox.home.comstyle.com> <51A08113.6010903@msgid.tls.msk.ru> In-Reply-To: <51A08113.6010903@msgid.tls.msk.ru> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-stable] [PATCH for 1.5] ui/gtk.c: Fix *BSD build of Gtk+ UI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: qemu-stable@nongnu.org, qemu-devel On 25/05/13 5:14 AM, Michael Tokarev wrote: > 24.05.2013 22:47, Brad Smith wrote: > >>>> +++ b/include/qemu-common.h >>>> #elif defined CONFIG_BSD >>>> +# include > >> Kinda late nit picking about it now. > > It's not. And it's not nitpicking really, we're > carrying a ton of unnecessary #includes which slows > down compilation significantly. I agree. > The whole this piece of #include twist was to get > declaration of openpty() or equivalent. You just > stiffed an unrelated #include into this piece which > was okay to remove completely. I already removed > it from several other .c files where it went from > vl.c originally, which used to have chardev code > which is now in another file. It was not unrelated, it was necessary for the BSD code path which utilizes openpty(). > What was the original issue? Where exactly it was > failing? I mean, where's the _proper_ place to > fix it? It was failing in the Gtk+ UI code due to the use of openpty(). -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.