Re: [Qemu-devel] [Qemu-stable] [PATCH for 1.5] ui/gtk.c: Fix *BSD build of Gtk+ UI

Re: [Qemu-devel] [Qemu-stable] [PATCH for 1.5] ui/gtk.c: Fix *BSD build of Gtk+ UI

[Michael Tokarev]

24.05.2013 22:47, Brad Smith wrote:

>>> +++ b/include/qemu-common.h
>>>  #elif defined CONFIG_BSD
>>> +# include <termios.h>

> Kinda late nit picking about it now.

It's not.  And it's not nitpicking really, we're
carrying a ton of unnecessary #includes which slows
down compilation significantly.

The whole this piece of #include twist was to get
declaration of openpty() or equivalent.  You just
stiffed an unrelated #include into this piece which
was okay to remove completely.  I already removed
it from several other .c files where it went from
vl.c originally, which used to have chardev code
which is now in another file.

What was the original issue?  Where exactly it was
failing?  I mean, where's the _proper_ place to
fix it?

Speaking of "too late" -- it is definitely not late
to fix another bug.

Thanks,

/mjt

Re: [Qemu-devel] [Qemu-stable] [PATCH for 1.5] ui/gtk.c: Fix *BSD build of Gtk+ UI

[Brad Smith]

On 25/05/13 5:14 AM, Michael Tokarev wrote:
> 24.05.2013 22:47, Brad Smith wrote:
>
>>>> +++ b/include/qemu-common.h
>>>>   #elif defined CONFIG_BSD
>>>> +# include <termios.h>
>
>> Kinda late nit picking about it now.
>
> It's not.  And it's not nitpicking really, we're
> carrying a ton of unnecessary #includes which slows
> down compilation significantly.

I agree.

> The whole this piece of #include twist was to get
> declaration of openpty() or equivalent.  You just
> stiffed an unrelated #include into this piece which
> was okay to remove completely.  I already removed
> it from several other .c files where it went from
> vl.c originally, which used to have chardev code
> which is now in another file.

It was not unrelated, it was necessary for the BSD
code path which utilizes openpty().

> What was the original issue?  Where exactly it was
> failing?  I mean, where's the _proper_ place to
> fix it?

It was failing in the Gtk+ UI code due to the use
of openpty().

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

Re: [Qemu-devel] [Qemu] [PATCH for 1.5] ui/gtk.c: Fix *BSD build of Gtk+ UI

[Michael Tokarev]

23.05.2013 02:38, Brad Smith wrote:
> Fix the build of the Gtk+ UI on *BSD systems.

Can you please describe what exactly was broken on *BSD
systems, -- which file(s) needs this additional
termios.h include?

I want to fix this properly, because now it isn't
"nitpicking", as you say, anymore -- after the
previous pbonzini's changes it does not build
on debian sparc anymore due to some conflicting
includes (which is an unrelated issue, but is
triggered now because every .c file includes
a ton of #defines).

I already asked you the same question on 25.05,
which is about two weeks ago by now, -- did you
had no time to reply so far?

Thanks,

/mjt

> Signed-off-by: Brad Smith <brad@comstyle.com>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> Message-id: 20130521161324.GA29977@rox.home.comstyle.com
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> 
> diff --git a/include/qemu-common.h b/include/qemu-common.h
> index af769f5..c944bb7 100644
> --- a/include/qemu-common.h
> +++ b/include/qemu-common.h
> @@ -45,6 +45,7 @@
>  #if defined(__GLIBC__)
>  # include <pty.h>
>  #elif defined CONFIG_BSD
> +# include <termios.h>
>  # if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || defined(__DragonFly__)
>  #  include <libutil.h>
>  # else
>