From: "Andreas Färber" <afaerber@suse.de>
To: peter.crosthwaite@xilinx.com
Cc: edgar.iglesias@gmail.com, qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 1/2] audio/intel-hda: Fix Inheritance hierachy
Date: Thu, 06 Jun 2013 13:47:32 +0200 [thread overview]
Message-ID: <51B076D4.9080101@suse.de> (raw)
In-Reply-To: <54453b6aa8afa1a76b2ec1932f1d7fd25205d0bc.1370496582.git.peter.crosthwaite@xilinx.com>
Am 06.06.2013 07:34, schrieb peter.crosthwaite@xilinx.com:
> From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
>
> The ich6 and ich9 variants either need to inherit one from the other,
> or both from a common base class, otherwise its not possible to create
> a QOM cast macro for use by the shared implementation functions.
> Went for option B, with a common base class.
>
> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Looks fine,
Reviewed-by: Andreas Färber <afaerber@suse.de>
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-06-06 11:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-06 5:34 [Qemu-devel] [PATCH v2 1/2] audio/intel-hda: Fix Inheritance hierachy peter.crosthwaite
2013-06-06 5:34 ` [Qemu-devel] [PATCH v2 2/2] audio/intel-hda: QOM casting sweep peter.crosthwaite
2013-06-06 11:47 ` Andreas Färber
2013-06-06 13:49 ` Gerd Hoffmann
2013-06-06 11:47 ` Andreas Färber [this message]
2013-06-06 13:49 ` [Qemu-devel] [PATCH v2 1/2] audio/intel-hda: Fix Inheritance hierachy Gerd Hoffmann
2013-06-17 21:06 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B076D4.9080101@suse.de \
--to=afaerber@suse.de \
--cc=edgar.iglesias@gmail.com \
--cc=kraxel@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).