From: Liu Yuan <namei.unix@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
sheepdog@lists.wpkg.org, qemu-devel@nongnu.org,
MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
Subject: Re: [Qemu-devel] [PATCH 2/2] sheepdog: support 'qemu-img snapshot -a'
Date: Thu, 06 Jun 2013 21:41:19 +0800 [thread overview]
Message-ID: <51B0917F.7080402@gmail.com> (raw)
In-Reply-To: <20130606124629.GE2586@dhcp-200-207.str.redhat.com>
On 06/06/2013 08:46 PM, Kevin Wolf wrote:
> I'm not sure how snapshots work internally for Sheepdog, but it seems
> odd to me that you need to do this only for disk-only snapshots, but not
> when the snapshot has VM state. (Also, note that 'qemu-img snapshot -a'
> works on images with a VM state, so the comment doesn't seem to be
> completely accurate)
Seems that I misunderstood your comments. What my 2/2 patch tried to do
is enable 'qemu-img snapshot -a' to rollback the sheepdog disk states
only and it is correct. So what I need fixing is comment, right?
how about the commenting as 'qemu-img asks us to rollback disk only, we
can't rely on the write request to sd_create_branch, so just call it
directly' ?
Thanks,
Yuan
prev parent reply other threads:[~2013-06-06 13:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-06 11:57 [Qemu-devel] [PATCH 0/2] fix 'qemu-img snapshot -a' operation for sheepdog Liu Yuan
2013-06-06 11:57 ` [Qemu-devel] [PATCH 1/2] sheepdog: fix snapshot tag initialization Liu Yuan
2013-06-06 12:46 ` Kevin Wolf
2013-06-06 11:57 ` [Qemu-devel] [PATCH 2/2] sheepdog: support 'qemu-img snapshot -a' Liu Yuan
2013-06-06 12:46 ` Kevin Wolf
2013-06-06 13:09 ` Liu Yuan
2013-06-07 7:31 ` Kevin Wolf
2013-06-07 13:48 ` Liu Yuan
2013-06-07 15:22 ` Kevin Wolf
2013-06-07 16:14 ` Liu Yuan
2013-06-07 16:48 ` Kevin Wolf
2013-06-07 17:23 ` Liu Yuan
2013-06-06 13:41 ` Liu Yuan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B0917F.7080402@gmail.com \
--to=namei.unix@gmail.com \
--cc=kwolf@redhat.com \
--cc=morita.kazutaka@lab.ntt.co.jp \
--cc=qemu-devel@nongnu.org \
--cc=sheepdog@lists.wpkg.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).