From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43341) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkaYu-0007Jd-9v for qemu-devel@nongnu.org; Thu, 06 Jun 2013 09:49:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UkaYt-0007M7-57 for qemu-devel@nongnu.org; Thu, 06 Jun 2013 09:49:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20702) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkaYs-0007M0-Sj for qemu-devel@nongnu.org; Thu, 06 Jun 2013 09:49:07 -0400 Message-ID: <51B0934F.1090203@redhat.com> Date: Thu, 06 Jun 2013 15:49:03 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <54453b6aa8afa1a76b2ec1932f1d7fd25205d0bc.1370496582.git.peter.crosthwaite@xilinx.com> In-Reply-To: <54453b6aa8afa1a76b2ec1932f1d7fd25205d0bc.1370496582.git.peter.crosthwaite@xilinx.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/2] audio/intel-hda: Fix Inheritance hierachy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: peter.crosthwaite@xilinx.com Cc: edgar.iglesias@gmail.com, qemu-devel@nongnu.org, afaerber@suse.de On 06/06/13 07:34, peter.crosthwaite@xilinx.com wrote: > From: Peter Crosthwaite > > The ich6 and ich9 variants either need to inherit one from the other, > or both from a common base class, otherwise its not possible to create > a QOM cast macro for use by the shared implementation functions. > Went for option B, with a common base class. > > Signed-off-by: Peter Crosthwaite Reviewed-by: Gerd Hoffmann cheers, Gerd