From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41251) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ukgdd-0002wi-Hg for qemu-devel@nongnu.org; Thu, 06 Jun 2013 16:18:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ukgdc-0004Yy-JG for qemu-devel@nongnu.org; Thu, 06 Jun 2013 16:18:25 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:51883) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ukgdc-0004Yu-Eh for qemu-devel@nongnu.org; Thu, 06 Jun 2013 16:18:24 -0400 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 6 Jun 2013 16:18:23 -0400 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id DFE32C90026 for ; Thu, 6 Jun 2013 16:18:20 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r56KILAW255182 for ; Thu, 6 Jun 2013 16:18:21 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r56KIJZO009062 for ; Thu, 6 Jun 2013 16:18:21 -0400 Message-ID: <51B0EE85.1000905@linux.vnet.ibm.com> Date: Thu, 06 Jun 2013 15:18:13 -0500 From: Jesse Larrew MIME-Version: 1.0 References: <20130606095456.GA7865@redhat.com> <51B0EA30.3020804@linux.vnet.ibm.com> <20130606200932.GB3837@redhat.com> In-Reply-To: <20130606200932.GB3837@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] virtio-net: put virtio net header inline with data List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dave Jones , "Michael S. Tsirkin" , Rusty Russell , "David S. Miller" , Jason Wang , Cong Wang , Amos Kong , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, qemu-devel@nongnu.org On 06/06/2013 03:09 PM, Dave Jones wrote: > On Thu, Jun 06, 2013 at 02:59:44PM -0500, Jesse Larrew wrote: > > > > pr_debug("%s: xmit %p %pM\n", vi->dev->name, skb, dest); > > > + if (vi->mergeable_rx_bufs) > > > + hdr_len = sizeof hdr->mhdr; > > > + else > > > + hdr_len = sizeof hdr->hdr; > > > > All conditionals need braces. > > Documentation/CodingStyle disagrees: > > "Do not unnecessarily use braces where a single statement will do." > > Dave > Ah, yes. This is kernel code. My mistake. :) Jesse Larrew Software Engineer, KVM Team IBM Linux Technology Center Phone: (512) 973-2052 (T/L: 363-2052) jlarrew@linux.vnet.ibm.com