From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ukvfe-0006Kw-7n for qemu-devel@nongnu.org; Fri, 07 Jun 2013 08:21:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ukvfc-0003qk-Of for qemu-devel@nongnu.org; Fri, 07 Jun 2013 08:21:30 -0400 Received: from mail-qe0-f41.google.com ([209.85.128.41]:64811) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkvY7-0001Mc-M7 for qemu-devel@nongnu.org; Fri, 07 Jun 2013 08:13:43 -0400 Received: by mail-qe0-f41.google.com with SMTP id b4so2684977qen.0 for ; Fri, 07 Jun 2013 05:13:43 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <51B1CE6A.1050306@redhat.com> Date: Fri, 07 Jun 2013 08:13:30 -0400 From: Paolo Bonzini MIME-Version: 1.0 References: <1370371954-8479-1-git-send-email-pbonzini@redhat.com> <51AF09FC.50308@suse.de> <51B13151.10709@redhat.com> <51B18F9A.7030900@suse.de> In-Reply-To: <51B18F9A.7030900@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: qemu-devel@nongnu.org, mst@redhat.com Il 07/06/2013 03:45, Andreas Färber ha scritto: > Am 07.06.2013 03:03, schrieb Paolo Bonzini: >> Il 05/06/2013 05:50, Andreas Färber ha scritto: >>> Also I notice some patches are accessing parent fields directly - please >>> use BUS(), PCI_DEVICE() etc. to hide this. >> >> I'm always using them. For example: >> >> +static void intel_hda_instance_finalize(Object *obj) >> +{ >> + PCIDevice *pci = PCI_DEVICE(obj); >> + IntelHDAState *d = DO_UPCAST(IntelHDAState, pci, pci); > > I'll comment inline then. :) Ah right, in those cases I was mostly doing what the adjacent/pre-existing code did. But I can definitely fix them up! Paolo