From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51934) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkwfP-0001sj-7t for qemu-devel@nongnu.org; Fri, 07 Jun 2013 09:25:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UkwfN-0000Hq-Oo for qemu-devel@nongnu.org; Fri, 07 Jun 2013 09:25:19 -0400 Received: from cantor2.suse.de ([195.135.220.15]:54953 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkwfN-0000Hd-Hb for qemu-devel@nongnu.org; Fri, 07 Jun 2013 09:25:17 -0400 Message-ID: <51B1DF3A.50302@suse.de> Date: Fri, 07 Jun 2013 15:25:14 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1370371954-8479-1-git-send-email-pbonzini@redhat.com> <51AF09FC.50308@suse.de> <51B13151.10709@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: Paolo Bonzini , "qemu-devel@nongnu.org Developers" , "Michael S. Tsirkin" Hi Peter, Am 07.06.2013 10:41, schrieb Peter Crosthwaite: > I have a series that fixes all qom cast macros for all PCI devices tree > wide. Can post. Qom cast macros added as needed. Sounds promising! I just CC'ed you on my ISA series v2, which touches on PCI_BUS() in the final patch, dropping FROM_QBUS(). > How are you regression testing this series? If you have a pc/PCI > regression suite I could use it for my series. I rely on `make check` to find the most obvious QOM errors. libqos PCI support is still very new, so we don't have full device coverage there yet. Usually I run an openSUSE and/or SLES guest under KVM (pick your favorite), which will exercise the relevant init, realize and reset code paths at least. And finally I re-review things in gitk before sending - not the nicest tool but convenient for fixing up things and verifying quickly. HTH, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg