From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37961) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UlEaZ-0003Zv-3t for qemu-devel@nongnu.org; Sat, 08 Jun 2013 04:33:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UlEaW-0007I9-8x for qemu-devel@nongnu.org; Sat, 08 Jun 2013 04:33:31 -0400 Received: from mail-pd0-f173.google.com ([209.85.192.173]:55668) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UlEaW-0007Hp-23 for qemu-devel@nongnu.org; Sat, 08 Jun 2013 04:33:28 -0400 Received: by mail-pd0-f173.google.com with SMTP id v14so1809987pde.4 for ; Sat, 08 Jun 2013 01:33:27 -0700 (PDT) Message-ID: <51B2EC50.6040604@ozlabs.ru> Date: Sat, 08 Jun 2013 18:33:20 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1370491146-10778-1-git-send-email-aik@ozlabs.ru> <1370491146-10778-3-git-send-email-aik@ozlabs.ru> <51B2DC25.2030506@msgid.tls.msk.ru> In-Reply-To: <51B2DC25.2030506@msgid.tls.msk.ru> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/2] KVM: PPC: Add dummy kvm_arch_init_irq_routing() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: qemu-trivial@nongnu.org, Alexander Graf , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, Scott Wood , David Gibson On 06/08/2013 05:24 PM, Michael Tokarev wrote: > 06.06.2013 07:59, Alexey Kardashevskiy wrote: >> From: Scott Wood >> >> The common KVM code insists on calling kvm_arch_init_irq_routing() >> as soon as it sees kernel header support for it (regardless of whether >> QEMU supports it). Provide a dummy function to satisfy this. >> >> Unlike x86, PPC does not have one default irqchip, so there's no common >> code that we'd stick here. Even if you ignore the routes themselves, >> which even on x86 are not set up in this function, the initial XICS >> kernel implementation will not support IRQ routing, so it's best to >> leave even the general feature flags up to the specific irqchip code. > > As Scott Wood already pointed out, this should come in before the > actual header update, which is no problem. We'll have to deal > with a new warning (-Wmissing-prototypes) which can be dealt with > by wrapping this function into #ifdef KVM_CAP_IRQ_ROUTING .. #endif > (I can add this). Ah. I'll repost it early next week. > > But how about other architectures? Before, this function were only > defined for x86, now it is defined for two arches - x86 and ppc. > Aren't other arches need this as well? Good point, will check (and fix if needed). Thanks! -- Alexey