From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51949) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ulue4-0006ui-5g for qemu-devel@nongnu.org; Mon, 10 Jun 2013 01:27:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ulue1-0008IZ-MN for qemu-devel@nongnu.org; Mon, 10 Jun 2013 01:27:56 -0400 Message-ID: <51B563CC.5040907@redhat.com> Date: Mon, 10 Jun 2013 07:27:40 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1370439748-18092-1-git-send-email-hpoussin@reactos.org> <51B2E26F.8030106@msgid.tls.msk.ru> In-Reply-To: <51B2E26F.8030106@msgid.tls.msk.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] ioport/memory: check that both .read and .write callbacks are defined List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: "Michael S. Tsirkin" , qemu-trivial@nongnu.org, qemu-devel@nongnu.org, Peter Crosthwaite , =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= , "Edgar E. Iglesias" , Paolo Bonzini Hi, > Maybe instead (or in addition to), we should provide a dummy > read or write functions -- instead of fixing each such occurence > to use its own dummy function Makes sense, especially for write where we can just ignore what the guest attempts to write. Not sure we can have a generic handler for reads. Maybe two, one which returns 0xff and one which returns 0x00. cheers, Gerd