From: Peter Lieven <pl@kamp.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Wenchao Xia <xiawenc@linux.vnet.ibm.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [Qemu-ppc] broken incoming migration
Date: Mon, 10 Jun 2013 11:42:25 +0200 [thread overview]
Message-ID: <51B59F81.2020304@kamp.de> (raw)
In-Reply-To: <1370856815.14883.53.camel@pasglop>
On 10.06.2013 11:33, Benjamin Herrenschmidt wrote:
> On Mon, 2013-06-10 at 19:10 +1000, Alexey Kardashevskiy wrote:
>>> I would prefer not to completely drop the patch since it saves bandwidth and
>>> resources.
>> I would like migration to do what it should do - send pages no matter what,
>> this is exactly what migration is for. If there any many, many empty pages
>> (which I doubt to be a very often real life case), they could all merged in
>> big consecutive chunks and sent at the end of migration.
> I tend to agree. The problem of sending empty pages is purely a problem of
> compression. If the current mechanism is deemed "not efficient enough" for
> in the case of having lots of zero-pages, then by all means invent a better
> packet format for more tightly representing them on the wire, but don't
> break things by not sending them at all.
Ok, I see the point. I think the paradigm to say that the destination
should "decide" if it needs a page or not is a sound one.
Zero pages are quite often depending on the lifetime and the operating
system used. But a consecutive range of zero pages is only likely
in the bulk stage. I don't know if its reasonable to add a special encoding
for that.
I will sent a v2 of my previous revert patch addressing Erics concerns shortly.
Peter
next prev parent reply other threads:[~2013-06-10 9:42 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 7:44 [Qemu-devel] broken incoming migration Alexey Kardashevskiy
2013-05-30 7:49 ` Alexey Kardashevskiy
2013-05-30 7:49 ` Paolo Bonzini
2013-05-30 8:18 ` Alexey Kardashevskiy
2013-05-30 9:08 ` Peter Lieven
2013-05-30 9:31 ` Alexey Kardashevskiy
2013-05-30 13:00 ` Paolo Bonzini
2013-05-30 13:38 ` Alexey Kardashevskiy
2013-05-30 14:08 ` Paolo Bonzini
2013-05-30 14:38 ` Peter Lieven
2013-05-30 14:41 ` Paolo Bonzini
2013-06-04 13:52 ` Peter Lieven
2013-06-04 14:14 ` Paolo Bonzini
2013-06-04 14:38 ` Peter Lieven
2013-06-04 14:40 ` Paolo Bonzini
2013-06-04 14:48 ` Peter Lieven
2013-06-04 15:17 ` Paolo Bonzini
2013-06-04 19:15 ` Peter Lieven
2013-06-05 3:37 ` Alexey Kardashevskiy
2013-06-05 6:09 ` Peter Lieven
2013-06-09 4:12 ` liu ping fan
2013-06-09 7:22 ` Peter Lieven
2013-06-04 15:10 ` Peter Lieven
2013-06-08 8:27 ` Wenchao Xia
2013-06-08 8:30 ` Alexey Kardashevskiy
2013-06-09 2:16 ` Wenchao Xia
2013-06-09 2:34 ` Alexey Kardashevskiy
2013-06-09 2:52 ` [Qemu-devel] [Qemu-ppc] " Benjamin Herrenschmidt
2013-06-09 3:01 ` Alexey Kardashevskiy
2013-06-09 3:01 ` [Qemu-devel] " Wenchao Xia
2013-06-09 3:09 ` Alexey Kardashevskiy
2013-06-09 3:31 ` Wenchao Xia
2013-06-09 7:27 ` Peter Lieven
2013-06-10 6:39 ` Alexey Kardashevskiy
2013-06-10 6:50 ` Peter Lieven
2013-06-10 6:55 ` Alexey Kardashevskiy
2013-06-10 8:44 ` Peter Lieven
2013-06-10 9:10 ` Alexey Kardashevskiy
2013-06-10 9:33 ` [Qemu-devel] [Qemu-ppc] " Benjamin Herrenschmidt
2013-06-10 9:42 ` Peter Lieven [this message]
2013-06-09 2:53 ` Benjamin Herrenschmidt
2013-06-12 14:00 ` Paolo Bonzini
2013-06-12 14:11 ` Benjamin Herrenschmidt
2013-06-12 20:10 ` Paolo Bonzini
2013-06-13 2:41 ` Wenchao Xia
2013-06-03 10:04 ` [Qemu-devel] " Alexey Kardashevskiy
2013-06-04 10:56 ` Peter Lieven
2013-06-08 8:24 ` Wenchao Xia
2013-05-30 10:18 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B59F81.2020304@kamp.de \
--to=pl@kamp.de \
--cc=aik@ozlabs.ru \
--cc=benh@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).