From: "Andreas Färber" <afaerber@suse.de>
To: peter.crosthwaite@xilinx.com
Cc: qemu-trivial@nongnu.org, edgar.iglesias@gmail.com,
aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v1 3/3] char/serial: serial_ioport_write: Factor out common code
Date: Mon, 10 Jun 2013 15:35:19 +0200 [thread overview]
Message-ID: <51B5D617.9060906@suse.de> (raw)
In-Reply-To: <3a93fbb6bbc96792cf7b85384a2317344b77ab13.1370236013.git.peter.crosthwaite@xilinx.com>
Am 03.06.2013 07:14, schrieb peter.crosthwaite@xilinx.com:
> From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
>
> These three lines are common to both FIFO and regular mode. Just factor
> them out to outside the if rather than replicate the same lines inside
> both if and else.
>
> Cc: qemu-trivial@nongnu.org
>
> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-06-10 13:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 5:11 [Qemu-devel] [PATCH v1 0/3] Serial cleanup peter.crosthwaite
2013-06-03 5:12 ` [Qemu-devel] [PATCH v1 1/3] char/serial: cosmetic fixes peter.crosthwaite
2013-06-10 13:32 ` Andreas Färber
2013-06-10 15:17 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-06-10 15:29 ` Michael Tokarev
2013-06-10 22:24 ` Peter Crosthwaite
2013-06-03 5:13 ` [Qemu-devel] [PATCH v1 2/3] char/serial: Use generic Fifo8 peter.crosthwaite
2013-06-03 5:14 ` [Qemu-devel] [PATCH v1 3/3] char/serial: serial_ioport_write: Factor out common code peter.crosthwaite
2013-06-10 13:35 ` Andreas Färber [this message]
2013-06-10 10:23 ` [Qemu-devel] [PATCH v1 0/3] Serial cleanup Peter Crosthwaite
2013-06-10 11:49 ` Andreas Färber
2013-06-10 12:09 ` Peter Crosthwaite
2013-06-11 11:23 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B5D617.9060906@suse.de \
--to=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=edgar.iglesias@gmail.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).