From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48450) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Um2LU-00037y-D3 for qemu-devel@nongnu.org; Mon, 10 Jun 2013 09:41:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Um2LQ-00036e-KF for qemu-devel@nongnu.org; Mon, 10 Jun 2013 09:41:16 -0400 Message-ID: <51B5D617.9060906@suse.de> Date: Mon, 10 Jun 2013 15:35:19 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <3a93fbb6bbc96792cf7b85384a2317344b77ab13.1370236013.git.peter.crosthwaite@xilinx.com> In-Reply-To: <3a93fbb6bbc96792cf7b85384a2317344b77ab13.1370236013.git.peter.crosthwaite@xilinx.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v1 3/3] char/serial: serial_ioport_write: Factor out common code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: peter.crosthwaite@xilinx.com Cc: qemu-trivial@nongnu.org, edgar.iglesias@gmail.com, aliguori@us.ibm.com, qemu-devel@nongnu.org Am 03.06.2013 07:14, schrieb peter.crosthwaite@xilinx.com: > From: Peter Crosthwaite >=20 > These three lines are common to both FIFO and regular mode. Just factor > them out to outside the if rather than replicate the same lines inside > both if and else. >=20 > Cc: qemu-trivial@nongnu.org >=20 > Signed-off-by: Peter Crosthwaite Reviewed-by: Andreas F=E4rber Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg