From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39049) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Um3Np-0003NR-AF for qemu-devel@nongnu.org; Mon, 10 Jun 2013 10:47:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Um3Nl-0008MU-F5 for qemu-devel@nongnu.org; Mon, 10 Jun 2013 10:47:45 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53407 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Um3Nl-0008MH-6b for qemu-devel@nongnu.org; Mon, 10 Jun 2013 10:47:41 -0400 Message-ID: <51B5E70A.3020001@suse.de> Date: Mon, 10 Jun 2013 16:47:38 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1370805206-26574-1-git-send-email-afaerber@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-cpu 00/59] QOM CPUState, part 10: CPU loops List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini Cc: Peter Maydell , qemu-devel@nongnu.org, Blue Swirl , Anthony Liguori , Paolo Bonzini , =?UTF-8?B?QXVyw6lsaWVuIEphcm5v?= Am 10.06.2013 16:17, schrieb Stefano Stabellini: > On Sun, 9 Jun 2013, Andreas F=C3=A4rber wrote: >> Hello, >> >> Based on my guest-memory-dump cleanup patches, this large series chang= es >> cpu_single_env, first_cpu, next_cpu and thread_env to CPUState. >> >> As a prerequisite, most open-coded CPU loops are replaced by either >> qemu_for_each_cpu() or qemu_get_cpu(). Individual review appreciated! >> >> qemu_init_vcpu() is converted to CPUState and moved away from targets. >> >> cpu_unassigned_access(), cpu_dump_state() and cpu_dump_statistics() ar= e turned >> into CPUClass methods. exec/hwaddr.h is modified to allows its use in = qom/cpu.h. >> >> Available for testing at: >> git://github.com/afaerber/qemu-cpu.git qom-cpu-10.v1 >> https://github.com/afaerber/qemu-cpu/commits/qom-cpu-10.v1 >> >> Regards, >> Andreas >> >> Cc: Anthony Liguori >> Cc: Blue Swirl >> Cc: Aur=C3=A9lien Jarno >> Cc: Paolo Bonzini (cpu_unassigned_access) >> Cc: Stefano Stabellini (dummy CPU t= hread changes) >> Cc: Peter Maydell (hwaddr) >> >> Andreas F=C3=A4rber (59): >> kvm: Change kvm_cpu_synchronize_state() argument to CPUState >> kvm: Change cpu_synchronize_state() argument to CPUState >> cpus: Simplify cpu_synchronize_all_post_reset() >> cpus: Simplify cpu_synchronize_all_post_init() >> cpus: Simplify pause_all_vcpus() >> cpus: Simplify resume_all_vcpus() >> cpus: Simplify set_numa_modes() >> cpus: Simplify qmp_inject_nmi() >> cpus: Simplify hw_error() >> cpus: Simplify qemu_tcg_wait_io_event() and qemu_tcg_cpu_thread_fn() >> monitor: Simplify do_inject_mce() >> gdbstub: Simplify find_cpu() >> cpu: Change cpu_exit() argument to CPUState >> cpus: Change cpu_thread_is_idle() argument to CPUState >> cpus: Change qemu_kvm_wait_io_event() argument to CPUState >> kvm: Change kvm_set_signal_mask() argument to CPUState >> cpus: Change qemu_kvm_init_cpu_signals() argument to CPUState >> cpu: Turn cpu_dump_{state,statistics}() into CPUState hooks >> kvm: Change kvm_handle_internal_error() argument to CPUState >> kvm: Change kvm_cpu_exec() argument to CPUState >> gdbstub: Set gdb_set_stop_cpu() argument to CPUState >> cpus: Change cpu_handle_guest_debug() argument to CPUState >> cpus: Change qemu_kvm_start_vcpu() argument to CPUState >> cpus: Change qemu_dummy_start_vcpu() argument to CPUState >> cpu: Change qemu_init_vcpu() argument to CPUState >> hwaddr: Make hwaddr type usable beyond softmmu >> cpu: Turn cpu_unassigned_access() into a CPUState hook >=20 > ^ > git-bisect tells me that this commit breaks Xen HVM support in QEMU Thanks, I'll look into it - any more detail as to how it breaks? SIGSEGV, assertion failure, guest misbehavior, ...? Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg