From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38133)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1UmHov-0007bF-UM
	for qemu-devel@nongnu.org; Tue, 11 Jun 2013 02:12:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1UmHou-0003Iv-W0
	for qemu-devel@nongnu.org; Tue, 11 Jun 2013 02:12:41 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41867)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1UmHou-0003Ir-Nz
	for qemu-devel@nongnu.org; Tue, 11 Jun 2013 02:12:40 -0400
Message-ID: <51B6BFD5.10005@redhat.com>
Date: Tue, 11 Jun 2013 08:12:37 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1370533048-19229-1-git-send-email-kraxel@redhat.com>
	<87mwr3ghk0.fsf@codemonkey.ws>
In-Reply-To: <87mwr3ghk0.fsf@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] fbdev: add linux framebuffer display
 driver.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org

  Hi,

>> +static QEMUCursor                 *ptr_cursor;
>> +static pixman_image_t             *ptr_image;
>> +static int                        ptr_refresh;
>> +static int                        px, py, pw, ph;
>> +static int                        mx, my, mon;
>> +
>> +/* options */
>> +static int                        use_scale;
>> +static pixman_filter_t            pfilter = PIXMAN_FILTER_GOOD;
> 
> Should stick all of this within a structure and pass it around where
> possible.

Don't see what this buys us as there can be only a single framebuffer
display anyway.  Can do that though.

>> +            if (qemu_console_is_graphic(NULL)) {
>> +                send_scancode(keycode, up);
>> +            } else if (!up) {
>> +                send_keysym(keycode, shift);
> 
> I'm confused here...  Why can't use use the normal keymap code with the
> keycode value?

keycode != keycode.  qemu uses ps/2 keycodes.  fbdev gets linux input
layer keycodes as input.

cheers,
  Gerd