From: "Andreas Färber" <afaerber@suse.de>
To: liguang <lig.fnst@cn.fujitsu.com>
Cc: qemu-trivial@nongnu.org, Tim Hardeck <thardeck@suse.de>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/5] vnc: pass bool pararmeter for vnc_connect
Date: Tue, 11 Jun 2013 13:39:38 +0200 [thread overview]
Message-ID: <51B70C7A.1070102@suse.de> (raw)
In-Reply-To: <1370927720-4348-1-git-send-email-lig.fnst@cn.fujitsu.com>
"parameter"
Am 11.06.2013 07:15, schrieb liguang:
> type last parameter of vnc_connect if bool,
"Type of last ...", "is"
> so pass 'false' instead of '0' for it.
>
> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
Michael, can you fix those up? Then,
Reviewed-by: Andreas Färber <afaerber@suse.de>
Thanks,
Andreas
> ---
> ui/vnc.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ui/vnc.c b/ui/vnc.c
> index dfc7459..7d22660 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -3283,7 +3283,7 @@ void vnc_display_open(DisplayState *ds, const char *display, Error **errp)
> if (csock < 0) {
> goto fail;
> }
> - vnc_connect(vs, csock, 0, 0);
> + vnc_connect(vs, csock, 0, false);
> } else {
> /* listen for connects */
> char *dpy;
> @@ -3345,5 +3345,5 @@ void vnc_display_add_client(DisplayState *ds, int csock, int skipauth)
> {
> VncDisplay *vs = vnc_display;
>
> - vnc_connect(vs, csock, skipauth, 0);
> + vnc_connect(vs, csock, skipauth, false);
> }
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-06-11 11:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 5:15 [Qemu-devel] [PATCH 1/5] vnc: pass bool pararmeter for vnc_connect liguang
2013-06-11 5:15 ` [Qemu-devel] [PATCH 2/5] vnc: pass bool parameter for vnc_listen_read liguang
2013-06-11 11:36 ` Andreas Färber
2013-06-11 5:15 ` [Qemu-devel] [PATCH 3/5] qemu-char: pass bool parameter for qemu_opt_get_bool liguang
2013-06-11 11:35 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-06-18 2:33 ` li guang
2013-06-11 5:15 ` [Qemu-devel] [PATCH 4/5] memory: use '=' instead of '|=' for memory_region_update_pending liguang
2013-06-11 11:34 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-06-18 2:32 ` li guang
2013-06-18 3:50 ` Michael Tokarev
2013-06-18 4:08 ` li guang
2013-06-11 5:15 ` [Qemu-devel] [PATCH 5/5] sd: pass bool parameter for sd_init liguang
2013-06-11 11:39 ` Andreas Färber [this message]
2013-06-11 11:50 ` [Qemu-devel] [Qemu-trivial] [PATCH 1/5] vnc: pass bool pararmeter for vnc_connect Michael Tokarev
2013-06-18 2:34 ` li guang
2013-06-18 2:35 ` Michael Tokarev
2013-06-18 2:36 ` li guang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B70C7A.1070102@suse.de \
--to=afaerber@suse.de \
--cc=lig.fnst@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thardeck@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).