* [Qemu-devel] [PATCH] target-sparc: Replace free by g_free
@ 2013-06-10 20:40 Stefan Weil
2013-06-11 12:13 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-06-11 12:27 ` [Qemu-devel] " Andreas Färber
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Weil @ 2013-06-10 20:40 UTC (permalink / raw)
To: qemu-trivial; +Cc: Blue Swirl, Stefan Weil, qemu-devel
The wrong function was reported by cppcheck.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
target-sparc/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-sparc/cpu.c b/target-sparc/cpu.c
index 290b580..13bb7bb 100644
--- a/target-sparc/cpu.c
+++ b/target-sparc/cpu.c
@@ -614,7 +614,7 @@ static int cpu_sparc_find_by_name(sparc_def_t *cpu_def, const char *cpu_model)
return 0;
error:
- free(s);
+ g_free(s);
return -1;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] target-sparc: Replace free by g_free
2013-06-10 20:40 [Qemu-devel] [PATCH] target-sparc: Replace free by g_free Stefan Weil
@ 2013-06-11 12:13 ` Michael Tokarev
2013-06-11 12:27 ` [Qemu-devel] " Andreas Färber
1 sibling, 0 replies; 3+ messages in thread
From: Michael Tokarev @ 2013-06-11 12:13 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, Blue Swirl, qemu-devel, Stefano Stabellini
Thanks, applied all 4(*) to trivial-patches queue.
(*)
target-sparc: Replace free by g_free
hw/scsi: Don't increment a boolean value
device tree: Fix cppcheck warning
hw/xen: Use g_free instead of free and fix potential memory leaks
(I think it wont hurt if the xen one will come from both -trivial
and xen trees, first one wins ;)
/mjt
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] target-sparc: Replace free by g_free
2013-06-10 20:40 [Qemu-devel] [PATCH] target-sparc: Replace free by g_free Stefan Weil
2013-06-11 12:13 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
@ 2013-06-11 12:27 ` Andreas Färber
1 sibling, 0 replies; 3+ messages in thread
From: Andreas Färber @ 2013-06-11 12:27 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, Blue Swirl, Michael Tokarev, qemu-devel
Am 10.06.2013 22:40, schrieb Stefan Weil:
> The wrong function was reported by cppcheck.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Andreas Färber <afaerber@suse.de>
> ---
> target-sparc/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-sparc/cpu.c b/target-sparc/cpu.c
> index 290b580..13bb7bb 100644
> --- a/target-sparc/cpu.c
> +++ b/target-sparc/cpu.c
> @@ -614,7 +614,7 @@ static int cpu_sparc_find_by_name(sparc_def_t *cpu_def, const char *cpu_model)
> return 0;
>
> error:
> - free(s);
> + g_free(s);
> return -1;
> }
>
So s is for the string, and matches occurrence above, fine.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-11 12:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-10 20:40 [Qemu-devel] [PATCH] target-sparc: Replace free by g_free Stefan Weil
2013-06-11 12:13 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-06-11 12:27 ` [Qemu-devel] " Andreas Färber
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).