From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50605) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UmSf3-0006HZ-03 for qemu-devel@nongnu.org; Tue, 11 Jun 2013 13:47:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UmSez-0002AE-Sg for qemu-devel@nongnu.org; Tue, 11 Jun 2013 13:47:12 -0400 Received: from cantor2.suse.de ([195.135.220.15]:59960 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UmSez-00029y-MG for qemu-devel@nongnu.org; Tue, 11 Jun 2013 13:47:09 -0400 Message-ID: <51B7629C.8050609@suse.de> Date: Tue, 11 Jun 2013 19:47:08 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1370794247-28267-1-git-send-email-afaerber@suse.de> <1370794247-28267-14-git-send-email-afaerber@suse.de> <20130611115256.76476459@redhat.com> In-Reply-To: <20130611115256.76476459@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-cpu v4 13/18] memory_mapping: Cleanup qemu_get_guest_memory_mapping() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qiaonuohan@cn.fujitsu.com, qemu-devel@nongnu.org Am 11.06.2013 17:52, schrieb Luiz Capitulino: > On Sun, 9 Jun 2013 18:10:42 +0200 > Andreas F=C3=A4rber wrote: >=20 >> We relied on the CPUClass::get_memory_mapping() implementation being a >> no-op when paging is disabled for that CPU. Therefore we can just as w= ell >> iterate over all CPUs to retrieve mappings. >> >> This allows to use qemu_for_each_cpu() instead of open-coding CPU loop= s. >> >> Pass any Error out into dump_init() and have it actually stop on error= s. >> Whether it is unsupported on a certain CPU can be checked by looking f= or >> a NULL CPUClass::get_memory_mapping field. >> >> Signed-off-by: Andreas F=C3=A4rber >=20 > Reviewed-by: Luiz Capitulino Thanks, reverted CPU loop changes and applied to qom-cpu as pure error handling improvement: https://github.com/afaerber/qemu-cpu/commits/qom-cpu Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg